Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli hub: refact/split files; add some doc/examples #3394

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 6, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jan 6, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title cscli: refact/split files; add some doc/examples cscli hub: refact/split files; add some doc/examples Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 83.34794% with 190 lines in your changes missing coverage. Please review.

Project coverage is 59.02%. Comparing base (5c7b957) to head (6a9832c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliitem/cmdinspect.go 36.90% 95 Missing and 11 partials ⚠️
cmd/crowdsec-cli/cliitem/hubappsec.go 87.16% 28 Missing and 1 partial ⚠️
cmd/crowdsec-cli/cliitem/cmdinstall.go 73.52% 23 Missing and 4 partials ⚠️
cmd/crowdsec-cli/cliitem/cmdremove.go 85.14% 10 Missing and 5 partials ⚠️
cmd/crowdsec-cli/cliitem/cmdupgrade.go 83.09% 8 Missing and 4 partials ⚠️
cmd/crowdsec-cli/cliitem/item.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3394      +/-   ##
==========================================
+ Coverage   58.51%   59.02%   +0.50%     
==========================================
  Files         356      358       +2     
  Lines       38226    38676     +450     
==========================================
+ Hits        22369    22827     +458     
+ Misses      13929    13923       -6     
+ Partials     1928     1926       -2     
Flag Coverage Δ
bats 42.22% <83.34%> (+0.69%) ⬆️
unit-linux 32.69% <0.00%> (-0.41%) ⬇️
unit-windows 28.07% <0.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review January 6, 2025 13:34
@mmetc mmetc merged commit 57d7247 into master Jan 6, 2025
17 checks passed
@mmetc mmetc deleted the hubops-cscli branch January 6, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants