You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The gopher-spree-api code looks pretty good so far! I think you've done a good job not abusing the Clean Architecture. Also, nice job on the utils package -- I wish Go gave us these utilities :(
In the spirit of sharing information and discussion: we've had some thoughts about Clean Architecture on the FoxComm team. Here are some notes, in the context of FoxComm, that I compiled as responses to Clean:
Some of my concerns for FoxComm do not apply to what you're building there is some relevance. For instance, your controllers are tightly coupled to gin which violates Independence of Frameworks a bit. So far, it looks like you've done a great job for testability -- I think its one of the most important points. If you're interested in talking more about it, let me know. @chischaschos is another resource because we've done a lot of chatting about the Clean Arch.
I look forward to seeing how this project shapes up!
The text was updated successfully, but these errors were encountered:
The
gopher-spree-api
code looks pretty good so far! I think you've done a good job not abusing the Clean Architecture. Also, nice job on theutils
package -- I wish Go gave us these utilities :(In the spirit of sharing information and discussion: we've had some thoughts about Clean Architecture on the FoxComm team. Here are some notes, in the context of FoxComm, that I compiled as responses to Clean:
Some of my concerns for FoxComm do not apply to what you're building there is some relevance. For instance, your controllers are tightly coupled to
gin
which violates Independence of Frameworks a bit. So far, it looks like you've done a great job for testability -- I think its one of the most important points. If you're interested in talking more about it, let me know. @chischaschos is another resource because we've done a lot of chatting about the Clean Arch.I look forward to seeing how this project shapes up!
The text was updated successfully, but these errors were encountered: