Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Architecture #49

Open
jpfuentes2 opened this issue Feb 23, 2015 · 0 comments
Open

Clean Architecture #49

jpfuentes2 opened this issue Feb 23, 2015 · 0 comments

Comments

@jpfuentes2
Copy link

The gopher-spree-api code looks pretty good so far! I think you've done a good job not abusing the Clean Architecture. Also, nice job on the utils package -- I wish Go gave us these utilities :(

In the spirit of sharing information and discussion: we've had some thoughts about Clean Architecture on the FoxComm team. Here are some notes, in the context of FoxComm, that I compiled as responses to Clean:

Some of my concerns for FoxComm do not apply to what you're building there is some relevance. For instance, your controllers are tightly coupled to gin which violates Independence of Frameworks a bit. So far, it looks like you've done a great job for testability -- I think its one of the most important points. If you're interested in talking more about it, let me know. @chischaschos is another resource because we've done a lot of chatting about the Clean Arch.

I look forward to seeing how this project shapes up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant