Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildProjectFileTranslation doesn't reset If-None-Match header on consecutive calls #195

Open
erickskrauch opened this issue Nov 6, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@erickskrauch
Copy link

The title 👆

This can be easily fixed by adding here an else block and calling the removeHeader() method:

if ($ifNoneMatch) {
$this->setHeader('If-None-Match', $ifNoneMatch);
}

Also, I would suggest changing the type of $ifNoneMatch from string to ?string since it accepts a null value.

@andrii-bodnar andrii-bodnar added good first issue Good for newcomers bug Something isn't working labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants