Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL Instance fills out endpoint field in ConnectionSecret in an unexpected way, breaking crossplane-contrib/sql-provider #778

Open
l0wl3vel opened this issue Jul 7, 2023 · 9 comments
Open

MySQL Instance fills out endpoint field in ConnectionSecret in an unexpected way, breaking crossplane-contrib/sql-provider #778

l0wl3vel opened this issue Jul 7, 2023 · 9 comments
Labels
bug Something isn't working needs:triage

Comments

@l0wl3vel
Copy link

l0wl3vel commented Jul 7, 2023

What happened?

When using the rds.aws.upbound.io/v1beta1/Instance Resource to create a database and writing the credentials to a connectionSecret the endpoint field unexpectedly includes a port in the endpoint field. This breaks compatibility with the https://github.com/crossplane-contrib/provider-sql Provider, due to it not supporting to use another field for its endpoint reference.

How can we reproduce it?

  1. Create a (MySQL) RDS Instace
  2. Configure a MySQL ProviderConfig
  3. Create some resource from the crossplane-contrib/sql-provider
  4. The following error will be displayed in the status of the sql-provider resource
observe failed: cannot select database: dial tcp: lookup
        db-name.[redacted].eu-central-1.rds.amazonaws.com:3306:3306: no
        such host

What environment did it happen in?

  • Crossplane Version: 1.12.1
  • Provider Version: 0.37.0
  • Kubernetes Version: 1.26.1
  • Kubernetes Distribution: Kubermatic KubeOne
@l0wl3vel l0wl3vel added bug Something isn't working needs:triage labels Jul 7, 2023
l0wl3vel added a commit to l0wl3vel/provider-aws that referenced this issue Jul 22, 2023
@l0wl3vel
Return the correct RDS Instance Endpoint in the ConnectionSecret
75a81c3 
Previously the ConnectionSecret endpoint field contained the hostname
including the port.

This is not expected behaviour and makes the ConnectionSecret unuseable
by downstream consumers of the Secret, like
https://github.com/crossplane-contrib/provider-sql, which expected
the endpoint and port to be in seperate fields.

Fixes: crossplane-contrib#778
l0wl3vel added a commit to l0wl3vel/provider-aws that referenced this issue Jul 22, 2023
@l0wl3vel
Return the correct RDS Instance Endpoint in the ConnectionSecret
c7bdded 
Previously the ConnectionSecret endpoint field contained the hostname
including the port.

This is not expected behaviour and makes the ConnectionSecret unuseable
by downstream consumers of the Secret, like
https://github.com/crossplane-contrib/provider-sql, which expected
the endpoint and port to be in seperate fields.

Fixes: crossplane-contrib#778
l0wl3vel added a commit to l0wl3vel/provider-aws that referenced this issue Jul 22, 2023
@l0wl3vel
Return the correct RDS Instance Endpoint in the ConnectionSecret
6991c88 
Previously the ConnectionSecret endpoint field contained the hostname
including the port.

This is not expected behavior and makes the ConnectionSecret unusable
by downstream consumers of the Secret, like
https://github.com/crossplane-contrib/provider-sql, which expect the
endpoint and port to be in separate fields.

Fixes: crossplane-contrib#778
l0wl3vel added a commit to l0wl3vel/provider-aws that referenced this issue Jul 22, 2023
@l0wl3vel
Return the correct RDS Instance Endpoint in the ConnectionSecret
5346dc6 
Previously the ConnectionSecret endpoint field contained the hostname
including the port.

This is not expected behavior and makes the ConnectionSecret unusable
by downstream consumers of the Secret, like
https://github.com/crossplane-contrib/provider-sql, which expect the
endpoint and port to be in separate fields.

Fixes: crossplane-contrib#778
Signed-off-by: Benjamin Ritter <[email protected]>
@l0wl3vel l0wl3vel mentioned this issue Jul 22, 2023
Closed
1 task
@STASiAN
Copy link

STASiAN commented Oct 4, 2023

Hi! I have same problem with postgresql ads instance. Any updates?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Apr 3, 2024
@pierluigilenoci
Copy link

/fresh

@github-actions github-actions bot removed the stale label Apr 6, 2024
@turkenf turkenf removed the community label May 9, 2024
@chlunde chlunde mentioned this issue May 27, 2024
Open
@Duologic Duologic mentioned this issue May 28, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 9, 2024
@pierluigilenoci
Copy link

/fresh

@pierluigilenoci
Copy link

/fresh again

@github-actions github-actions bot removed the stale label Aug 18, 2024
@lah-wag lah-wag mentioned this issue Sep 20, 2024
Closed
@github-actions GitHub Actions
Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Nov 16, 2024
@pierluigilenoci
Copy link

/fresh again and again

@github-actions github-actions bot removed the stale label Nov 19, 2024
This was referenced Nov 28, 2024
Open
Open
@pierluigilenoci
Copy link

FYI #1578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs:triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return RDS Instance Endpoint field in the ConnectionSecret without port l0wl3vel/provider-aws
5 participants
@STASiAN @jeanduplessis @l0wl3vel @pierluigilenoci @turkenf