chore(deps): update to Crossplane runtime 1.14.1, upjet 1.1.0 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <[email protected]>
go get github.com/crossplane/[email protected] && go mod tidy make generate Signed-off-by: Marques Johansson <[email protected]>
Updated from upbound/upjet tp crossplane/upjet Signed-off-by: Marques Johansson <[email protected]>
…mplate Signed-off-by: Marques Johansson <[email protected]>
For .github/ CI and Makefile: - update go to 1.21 - build/ to latest - golanci-lint to 1.54.2 Signed-off-by: Marques Johansson <[email protected]>
displague
force-pushed
the
crossplane-runtime-1.14.1
branch
from
e475ea3 to
10b1b2c
Compare
|
My local build environment has 1.21. This may have led to the go.mod files including toolgen which is a 1.21 flag. I attempted to update the CI and Makefile to go 1.21 and then ran into linting and build errors on this line: I think the next step would be to revert to 1.19 to match upstream and regenerate go.mod using a 1.19 format |
💫 |
….21 usage Signed-off-by: Marques Johansson <[email protected]>
displague
force-pushed
the
crossplane-runtime-1.14.1
branch
from
0fcdb42 to
bc36ba8
Compare
|
Attempted to copy some enhancements over from provider-aws, which is already adapted to go 1.21, but there are many more features that would need to be copied over. |
|
Largely covered by #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #29
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested