secretInjectionConfig applied when expectedResponse is false

[drewburr]

What happened?

When using a DisposableRequest, we are hoping to use expectedResponse as a way to stop processing if the response is not expected. For example, the below object shows that a 500 error was returned, and the body does not have the password key. We see that the DisposableRequest does not become ready, but secretInjectionConfigs seems to still run and we receive an unexpected object in our secret.

I wanted to check if this is expected, or if there is a configuration point we've missed that would prevent the body from being used to create a secret when expectedResponse is falsey. The hope would be that the secret would only be templated when the response passes the JQ test.

apiVersion: http.crossplane.io/v1alpha2
kind: DisposableRequest
spec:
  deletionPolicy: Orphan
  forProvider:
    body: |-
      { ... }
    expectedResponse: .body.password != null
    method: POST
    secretInjectionConfigs:
    - keyMappings:
      - responseJQ: .body | tostring
        secretKey: example-key
      secretRef:
        name: example-secret-name
        namespace: example-secret-namespace
  response:
    body: '{"statusCode":500,"error":"Internal Server Error","message":"An internal
      server error occurred"}'

Resulting secret data:

{
  "example-key": "{\"error\":\"Internal Server Error\",\"message\":\"An internal server error occurred\",\"statusCode\":500}"
}

How can we reproduce it?

Please let me know if a more complete example is needed, I could likely create something that uses a public facing API

What environment did it happen in?

Crossplane version: v1.17.1
K8s version: v1.29.8