Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202: Add Support for PlainHTTP for flexibility in chart downloads #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ioannis-matzaris
Copy link

@ioannis-matzaris ioannis-matzaris commented Dec 2, 2024

Add Support for PlainHTTP

Fixes #202

  • Added PlainHTTP, which enables insecure HTTP connections for chart downloads
    • useful in specific scenarios where secure connections are unavailable.
  • Extended support for PlainHTTP across all relevant operations:
    • Install (InstallAction)
    • Upgrade (UpgradeAction)
    • Pull (PullAction)
  • Updated CRD schema (helm.crossplane.io_releases.yaml) to include the new PlainHTTP field in the spec.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review. There is no reviewable step in the Makefile

How has this code been tested

  • manually deployed thepackage/crds/*
  • deployed the examples/sample/release.yaml by adding an extra line after L17 plainHTTP: true, without any errors. Before my changes, this line would have caused an error

Signed-off-by: Ioannis Matzaris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pull Charts from Private Registry
1 participant