This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Fix Alchemy.Reactions.Emoji.resolve/1 crashing all reaciton management related functions
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramsm
commented
Sep 23, 2020
| @@ -4,7 +4,7 @@ defmodule Alchemy.Mixfile do | |||
| def project do | |||
| [ | |||
| app: :alchemy, | |||
| version: "0.6.6", | |||
| version: "0.6.8", | |||
There was a problem hiding this comment.
@cronokirby I'm assuming the last PR (#110) was version 0.6.7 so I jumped to 0.6.8 =P
|
@cronokirby how are you? I would like to know if you could merge this PR. Also, since the PR fixing the channels did not bring up the project version, I can not pull that update from this lib and my bot is crashing since I have an annoucement channel on my server now. Merging this PR would fix the project version too. |
aramsm
force-pushed
the
fix/reaction-management
branch
from
4f5c197 to
14a09eb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Description
The
Alchemy.Reactions.Emoji.resolve/1considers only two scenarios:In this second scenario, this function is building the struct in a wrong way when the paramater is a map. This causes Elixir to crash when it tries to convert the emoji's name to string (this is required to build the url, so Uri can encode it here for example). With this fix, this function will do a proper job when the parameter is a map.