-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API: Allow for full-fledged processing of protection profiles #72
Comments
@J08nY I did some brief requirement analysis on this:
I'm wondering what are the benefits of implementing this?
@mukrop all in all, I think this should fit 40 hours of work... |
This is already done, see for example this. If the format would change it would need changes though.
Well the up-to-date part is quite important I think. Without considering PPs I believe our analysis is incomplete, also see #157 for example. In general the current PP dataset is not of great quality, many PPs are missing IDs and thus many certificates that have PPs do not display them properly because we will not match them (even after my matching fix goes through). |
@J08nY so, this has a green light from @mukrop, meaning I'll implement it over the course of November (hopefully). Design-wise, I think that the primary key must be pp name + pp link, as that's the only information that's available from the certificate list page. Do you have any other specific requirements on this, or do I proceed as I deem fitting and consult when needed? |
Please make the primary key only the PP filename as is done for the new dgst building in CC certificate, there is a function for that in sanitization helpers. This way we won't get screwed if they change the paths again. |
1 similar comment
Please make the primary key only the PP filename as is done for the new dgst building in CC certificate, there is a function for that in sanitization helpers. This way we won't get screwed if they change the paths again. |
Currently, the static dataset of protection profiles is loaded from web storage. This dataset was created using old API.
The new tool should allow for full processing of protection profiles without downloading the static dataset.
The text was updated successfully, but these errors were encountered: