Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start collecting dataset version #338

Open
adamjanovsky opened this issue May 19, 2023 · 1 comment
Open

Start collecting dataset version #338

adamjanovsky opened this issue May 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@adamjanovsky
Copy link
Collaborator

adamjanovsky commented May 19, 2023

When collecting a CC/FIPS dataset, we could collect the tool versions used to produce such datasets. When the user fetches from_web_latest(), we could display a warning when different version is run. We could assist the user by displaying him how to install the tool of that specific release. E.g., pip install sec-certs xxx.

Care must be taken when dealing with datasets created with commit x, but updated on commit y.

TODO

  • Create a new attribute sec_certs_version of DatasetInternalState and populate it with version obtained from setuptools_scm when a dataset is created.
  • Design it so that the attribute is filled only when dataset is created, not when dataset is updated, de/serialized, etc.
  • When a dataset is loaded, compare the current tool version with the dataset version. If mismatch, log warning.
@adamjanovsky adamjanovsky added the enhancement New feature or request label May 19, 2023
@adamjanovsky adamjanovsky self-assigned this Jul 13, 2023
@adamjanovsky adamjanovsky removed their assignment Sep 14, 2023
@GeorgeFI
Copy link
Collaborator

@adamjanovsky Hi there, I am continuing with this one.

@GeorgeFI GeorgeFI self-assigned this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants