Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Weapons created in Foundry do not create parry and block #2036

Open
IHappyEndI opened this issue Nov 25, 2024 · 4 comments
Open

[Bug] Weapons created in Foundry do not create parry and block #2036

IHappyEndI opened this issue Nov 25, 2024 · 4 comments

Comments

@IHappyEndI
Copy link

When you use inventory in foundry (i.e. you don't import weapons from "GCS", but create them as an item in foundry), then block and parry are not calculated for them

@chrismaille
Copy link
Contributor

Using the file test.cgs available in Discord:

Using Foundry Items:

FoundryItem

Using Actor Components

ActorComponent

The traits key in test.gcs

{
	"traits": [
		{
			"id": "tqj42LxM3rQ7p2Gd4",
			"name": "Естественная атака",
			"reference": "B271",
			"weapons": [
				{
					"id": "wYJf741QOGbZ9xg1t",
					"damage": {
						"type": "cr",
						"st": "thr",
						"base": "-1"
					},
					"usage": "Укус",
					"reach": "C",
					"defaults": [
						{
							"type": "dx"
						},
						{
							"type": "skill",
							"name": "Драка"
						}
					],
					"calc": {
						"level": 10,
						"damage": "1d-3 cr"
					}
				},
				{
					"id": "wFtE3rEZmq8lZHiZF",
					"damage": {
						"type": "cr",
						"st": "thr",
						"base": "-1"
					},
					"usage": "Удар",
					"reach": "C",
					"parry": "0",
					"defaults": [
						{
							"type": "dx"
						},
						{
							"type": "skill",
							"name": "Бокс"
						},
						{
							"type": "skill",
							"name": "Драка"
						},
						{
							"type": "skill",
							"name": "Каратэ"
						}
					],
					"calc": {
						"level": 10,
						"damage": "1d-3 cr",
						"parry": "8"
					}
				},
				{
					"id": "wfczYJp442J4KNRJ6",
					"damage": {
						"type": "cr",
						"st": "thr"
					},
					"usage": "Пинок",
					"reach": "C,1",
					"defaults": [
						{
							"type": "dx",
							"modifier": -2
						},
						{
							"type": "skill",
							"name": "Драка",
							"modifier": -2
						},
						{
							"type": "skill",
							"name": "Удар ногой"
						},
						{
							"type": "skill",
							"name": "Каратэ",
							"modifier": -2
						}
					],
					"calc": {
						"level": 8,
						"damage": "1d-2 cr"
					}
				}
			],
			"calc": {
				"points": 0
			}
		},
          ...
     ]
}

Looking at the GCS/JSON file, the equipment was exported as a trait, and in the weapons section, only one Parry was exported. No Block was found in GCS file for this equipment.

It's seems, at first, system correctly import the GCS file. If you send another file I can check again.

@IHappyEndI
Copy link
Author

@chrismaille Good afternoon! I probably don't write well in English, which is why there was such a misunderstanding. This error, if you can call it that, is not related to the import.

The problem is that the weapon that was originally created in the foundry ("GCS" is not involved here at all) or weapons imported by the library from "GCS" (i.e. also considered to be the item of the foundry), and not in the character, do not have parry and block calculation fields. You need to manually enter the calculated value of the final protection in the line "Parry Bonus" or "Block bonus". Is it possible to calculate such protection for a weapon automatically from a skill, or were these fields originally needed for this?

@IHappyEndI
Copy link
Author

IHappyEndI commented Nov 26, 2024

For example, screenshots from the foundry. Here there is a customized weapon in the foundry, but when you drag it to the sheet, it will have a parry of 0.
image
image

But using the example of the same weapon in GCS, there should be a parry of 5
image

@Tunzen
Copy link

Tunzen commented Nov 27, 2024

GGA can't calculate Parry, but pick whatever number is in Weapon Item Parry field, skill level OTF also not picked (no difference for Weapon Items imported from GCS eqt lib or created straight in foundry)
AFAIK it is not possible in GGA to automate such calculation right now (at least if it's not addition and subtraction operations).
Writing skill level OTF with division not working, too (probably operator issue because of "/"-sign).
image

@mjeffw mjeffw changed the title Weapons created in Foundry do not create parry and block [Bug] Weapons created in Foundry do not create parry and block Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants