Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Imports is deprecated and will be removed in M73 #28

Open
BenjaminHoegh opened this issue Apr 29, 2019 · 9 comments
Open

HTML Imports is deprecated and will be removed in M73 #28

BenjaminHoegh opened this issue Apr 29, 2019 · 9 comments

Comments

@BenjaminHoegh
Copy link

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

@crilleengvall
Copy link
Owner

@BenjaminHoegh Thanks for the heads up! I'll take a look at it when possible.

@borsTiHD
Copy link

@crilleengvall Hi, thanks for your great and simple tutorial.
This is my first time experimenting with electron.
I want to use your turorial to get a menu working, but I have the same issue as @BenjaminHoegh above. My menu isn't working. :(

I'm using "node 12.0.0", "Chrome 73.0.3683.121" and "Electron 5.0.2".
So I think this is why nothing happens on my side?

Please help. :)

@crilleengvall
Copy link
Owner

Hi @borsTiHD !

I'm glad the tutorials have been helping. I will look in to this issue. Unfortunately im far behind schedule right now.

@crilleengvall
Copy link
Owner

@borsTiHD I've updated the app to use electron v5 now. The latest commit supports v5.0.8.

@shaneth4312
Copy link

@borsTiHD I've updated the app to use electron v5 now. The latest commit supports v5.0.8.

Do you know when an updated tutorial will be released?

Im just getting into Electron and this is a great tutorial on how to start off. Even though after I finished, it didnt work due to 'said' issue. I did learn a lot.

I am not going through your updated project to figure out how you fixed it and though I'm understanding most of it, it would be a lot easier understanding from your perspecting why and how you done it.

Understandably you're busy, but thank you so far!

@yosiasz
Copy link

yosiasz commented Feb 23, 2021

Waiting for next release of this amazing tutorial for latest version of electron!

@crilleengvall
Copy link
Owner

Waiting for next release of this amazing tutorial for latest version of electron!

Thanks for your kind words @yosiasz!
I really like Electron and the kind response to the Electron tutorials from the community so I would really like to update them but unfortunately I don't have the time right now. But maybe one day!

@yosiasz
Copy link

yosiasz commented Feb 26, 2021

no worries. in that case I will be happy to start looking at updating it for the community to v11 of electron! here we go! you have already done a great job

@yosiasz
Copy link

yosiasz commented Feb 26, 2021

@crilleengvall here it is v9.4.3 with electron-forge

https://github.com/yosiasz/electron-tutorial-app

Any versions after 9 it breaks because of all the jquery and js file loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants