Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng build --prod $icon reference incorrect in scss file #8

Open
jdcargile opened this issue Mar 30, 2020 · 6 comments
Open

ng build --prod $icon reference incorrect in scss file #8

jdcargile opened this issue Mar 30, 2020 · 6 comments

Comments

@jdcargile
Copy link

This issue is in reference to the Angular version of Argon Design System.
https://www.creative-tim.com/new-issue/argon-design-system-angular

Issue: Performing ng build --prod fails with the following error.

92% chunk asset optimization optimize-css-webpack-pluginAn unhandled exception occurred: Lexical error on line 1: Unrecognized text.

  Erroneous area:
1: 100% - $icon-size-xl - 1
^.........^
@jdcargile
Copy link
Author

jdcargile commented Mar 30, 2020

@timcreative , I actually have a fix for this if you want to give me access to submit a new branch and PR.

EDIT: I forked and created a PR.

jdcargile added a commit to flannelware/argon-design-system-angular that referenced this issue Apr 15, 2020
Fixes creativetimofficial#8 with $icon-size references in the _icons.scss file that was causing ng build --prod to fail.
@netlander
Copy link

netlander commented May 27, 2020

@jdcargile, It doesn't look like it happened but did you manage to get this change committed to the master branch?

@jdcargile
Copy link
Author

jdcargile commented May 27, 2020

@netlander, unfortunately not. The PR has been submitted and sent over to @timcreative, but no response from Mar 30. 2020.

@netlander
Copy link

@jdcargile nevermind, thanks for the fixes, they are easy enough to apply manually.

@jdcargile
Copy link
Author

I’m glad it was helpful! Happy coding!

@khaoulaarfaoui
Copy link

@jdcargile can u tell me how u fixed it.. i still have the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants