New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback #1

Open

Stradivario opened this issue Jun 11, 2020 · 1 comment

Stradivario commented Jun 11, 2020

Hello there! I am just passing here to ask some questions

Why do you think that wrapping LocalStorage with Promise will give you a better performance ?
Do you know that wrapping Sync function with Async doesn't really give you asyncronious behaviour ?
Have you consider using this library ? https://github.com/localForage/localForage i think you will love it since it is wrapper for LocalStorage, IndexedDb or WebSQL.

Nothing in personal i just check your code and i was curious if you think about these scenarios!

Best Regards,
Kristiyan Tachev

vzakharov commented Jan 12, 2023

Yeah, looking at the code, it just defers the execution until the call stack is empty, but it will still block execution afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment