Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number and size of entries #14

Open
guillaumerose opened this issue Apr 19, 2021 · 0 comments
Open

Limit the number and size of entries #14

guillaumerose opened this issue Apr 19, 2021 · 0 comments

Comments

@guillaumerose
Copy link
Contributor

One attacker could possibly call the admin-helper to add a large number of host files entries or very long DNS names.
We should do something for that.

original comment: crc-org/crc#1793 (comment)

Hmm, any process in the VM can fill the host root filesystem, and maybe slow down name resolution? (dunno if huge /etc/hosts has a noticeable impact on name resolution). I did not check the admin-helper code, but we can limit the number of aliases we add to a few hundreds, and also limit their individual size (which is done already I think), which would address this concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant