Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-exporter 0.16.0 #676

Merged
merged 1 commit into from
Nov 18, 2024
Merged

sql-exporter 0.16.0 #676

merged 1 commit into from
Nov 18, 2024

Conversation

goat-ssh
Copy link
Contributor

Summary of changes

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2111
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@cla-bot cla-bot bot added the cla-signed label Nov 15, 2024
@goat-ssh goat-ssh requested review from Taliik and WalBeh November 15, 2024 16:37
WalBeh
WalBeh approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@WalBeh WalBeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should test it on dev before we bring it to production. Plus updating our own clusters on DEV(!).

@goat-ssh goat-ssh merged commit ff075a8 into master Nov 18, 2024
6 checks passed
@goat-ssh goat-ssh deleted the s/exporter-0.16 branch November 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalBeh WalBeh WalBeh approved these changes

@Taliik Taliik Awaiting requested review from Taliik

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goat-ssh @WalBeh