Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] Is there any plan to add support for kaslr on arm platform. #178

Open
zhageww opened this issue Apr 6, 2024 · 1 comment
Open

Comments

@zhageww
Copy link

zhageww commented Apr 6, 2024

Hello,

Currently, the code for function 'calc_kaslr_offset' just return FALSE, thus the kimage_voffset of qemu dumped core file could not obtained. Which leads to the failure of parsing the qemu dumped core file on the Arm platform.

So, I am wandering if there is any plan to add support for that?
much thanks.

PS: function 'calc_kaslr_offset' on Arm platform:

int
calc_kaslr_offset(ulong *kaslr_offset, ulong *phys_page)
{
return FALSE;
}

@liutgnu
Copy link
Member

liutgnu commented Apr 10, 2024

Hi @zhageww,

Thanks for raising the issue. As far as I know, currently there is no plan for the support. Any PRs are welcomed if you are interested in this task.

Thanks,
Tao Liu

jang574 pushed a commit to jang574/crash that referenced this issue Jun 21, 2024
The crash-utility has its own strlcpy(), but recently the latest glibc
has also implemented the strlcpy function, which is derived from
OpenBSD.  Eventually this caused the following compilation error:

  # make -j8 lzo
  ...
  In file included from global_data.c:18:
  defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’}
   5556 | size_t strlcpy(char *, char *, size_t);
        |        ^~~~~~~
  In file included from memory.c:19:
  defs.h:5556:8: error: conflicting types for ‘strlcpy’; have ‘size_t(char *, char *, size_t)’ {aka ‘long unsigned int(char *, char *, long unsigned int)’}
   5556 | size_t strlcpy(char *, char *, size_t);
        |        ^~~~~~~
  ...

To fix the issue, let's declare the strlcpy() as a weak function and
keep the same parameter types as the glibc function has.

Related glibc commits:
454a20c8756c ("Implement strlcpy and strlcat [BZ crash-utility#178]")
d2fda60e7c40 ("manual: Manual update for strlcat, strlcpy, wcslcat, wclscpy")
388ae538ddcb ("hurd: Add strlcpy, strlcat, wcslcpy, wcslcat to libc.abilist")

Signed-off-by: Lianbo Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants