Allow for set_no_numbers format #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are not required to have numbers, and although this is not the best way to group a diag with an assertion anyway, the full fix is more intrusive.
|
+1 from me. Numbers are not guaranteed, this fixes an issue a few people (including me) have had with this. |
|
I can look at this this evening. |
|
I did have issues with the tests being super flaky just like this. They seemed to not get the full output from the test run and it got cut off before the Result: PASS. |
toddr
approved these changes
Oct 4, 2023
|
@toddr Can we get a release on this soonish? Or do we still need something else to happen first? |
|
yep. will look at it today. |
|
I'm unable to ship this because make test is failing. |
|
Tests were fixed by 8eff75d. This is now on CPAN as 1.000005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are not required to have numbers, if they don't we skip the duplicate test check.
While here, only calculate the full "test_name" once.
This should resolve #16