From a64adb0766bcd2ded607d7e56c700a98719b324c Mon Sep 17 00:00:00 2001
From: Ldoppea <yannick.chiron@gmail.com>
Date: Mon, 26 Aug 2024 18:15:55 +0200
Subject: [PATCH] feat: Use new `downloadFile()` method from cozy-client

In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`react/Vierwer/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
---
 react/Viewer/NoViewer/DownloadButton.jsx      |  6 +++--
 .../Viewer/ViewersByFile/PdfMobileViewer.jsx  |  7 ++++--
 react/Viewer/components/Toolbar.jsx           |  6 +++--
 react/Viewer/helpers.js                       |  7 ------
 react/Viewer/helpers.spec.js                  | 25 -------------------
 5 files changed, 13 insertions(+), 38 deletions(-)

diff --git a/react/Viewer/NoViewer/DownloadButton.jsx b/react/Viewer/NoViewer/DownloadButton.jsx
index 1a873bccec..577bf89517 100644
--- a/react/Viewer/NoViewer/DownloadButton.jsx
+++ b/react/Viewer/NoViewer/DownloadButton.jsx
@@ -2,18 +2,20 @@ import PropTypes from 'prop-types'
 import React from 'react'
 
 import { withClient } from 'cozy-client'
+import { downloadFile } from 'cozy-client/dist/models/file'
+import { useWebviewIntent } from 'cozy-intent'
 
 import Button from '../../deprecated/Button'
 import { FileDoctype } from '../../proptypes'
 import { useI18n } from '../../providers/I18n'
-import { downloadFile } from '../helpers'
 
 const DownloadButton = ({ client, file, url }) => {
   const { t } = useI18n()
+  const webviewIntent = useWebviewIntent()
 
   return (
     <Button
-      onClick={() => downloadFile({ client, file, url })}
+      onClick={() => downloadFile({ client, file, url, webviewIntent })}
       label={t('Viewer.download')}
     />
   )
diff --git a/react/Viewer/ViewersByFile/PdfMobileViewer.jsx b/react/Viewer/ViewersByFile/PdfMobileViewer.jsx
index 6368d6b12c..0060e592d0 100644
--- a/react/Viewer/ViewersByFile/PdfMobileViewer.jsx
+++ b/react/Viewer/ViewersByFile/PdfMobileViewer.jsx
@@ -2,6 +2,8 @@ import PropTypes from 'prop-types'
 import React, { useState, useEffect, useRef, useCallback } from 'react'
 
 import { useClient } from 'cozy-client'
+import { downloadFile } from 'cozy-client/dist/models/file'
+import { useWebviewIntent } from 'cozy-intent'
 
 import styles from './styles.styl'
 import FileImageLoader from '../../FileImageLoader'
@@ -19,6 +21,7 @@ export const PdfMobileViewer = ({ file, url, t, gestures }) => {
   const { showAlert } = useAlert()
 
   const client = useClient()
+  const webviewIntent = useWebviewIntent()
 
   const onImageError = () => {
     setLoading(false)
@@ -32,7 +35,7 @@ export const PdfMobileViewer = ({ file, url, t, gestures }) => {
   const handleOnClick = useCallback(
     async file => {
       try {
-        await client.collection('io.cozy.files').download(file)
+        await downloadFile({ client, file, webviewIntent })
       } catch (error) {
         showAlert({
           message: t('Viewer.error.generic'),
@@ -42,7 +45,7 @@ export const PdfMobileViewer = ({ file, url, t, gestures }) => {
         })
       }
     },
-    [client, showAlert, t]
+    [client, showAlert, t, webviewIntent]
   )
 
   useEffect(() => {
diff --git a/react/Viewer/components/Toolbar.jsx b/react/Viewer/components/Toolbar.jsx
index 3e28886974..15e7c98fd7 100644
--- a/react/Viewer/components/Toolbar.jsx
+++ b/react/Viewer/components/Toolbar.jsx
@@ -3,6 +3,8 @@ import PropTypes from 'prop-types'
 import React from 'react'
 
 import { useClient } from 'cozy-client'
+import { downloadFile } from 'cozy-client/dist/models/file'
+import { useWebviewIntent } from 'cozy-intent'
 
 import PrintButton from './PrintButton'
 import { ToolbarFilePath } from './ToolbarFilePath'
@@ -17,7 +19,6 @@ import withBreakpoints from '../../helpers/withBreakpoints'
 import { useI18n } from '../../providers/I18n'
 import { makeStyles } from '../../styles'
 import { extractChildrenCompByName } from '../Footer/helpers'
-import { downloadFile } from '../helpers'
 import { useEncrypted } from '../providers/EncryptedProvider'
 
 const useClasses = makeStyles(theme => ({
@@ -42,6 +43,7 @@ const Toolbar = ({
   const client = useClient()
   const classes = useClasses()
   const { t } = useI18n()
+  const webviewIntent = useWebviewIntent()
 
   const { url } = useEncrypted()
 
@@ -88,7 +90,7 @@ const Toolbar = ({
             <IconButton
               className="u-white"
               aria-label={t('Viewer.download')}
-              onClick={() => downloadFile({ client, file, url })}
+              onClick={() => downloadFile({ client, file, url, webviewIntent })}
             >
               <Icon icon={DownloadIcon} />
             </IconButton>
diff --git a/react/Viewer/helpers.js b/react/Viewer/helpers.js
index ddc46450da..a18d11e202 100644
--- a/react/Viewer/helpers.js
+++ b/react/Viewer/helpers.js
@@ -46,13 +46,6 @@ export const isValidForPanel = ({ file }) => {
   )
 }
 
-export const downloadFile = async ({ client, file, url }) => {
-  if (isEncrypted(file)) {
-    return client.collection('io.cozy.files').forceFileDownload(url, file.name)
-  }
-  return client.collection('io.cozy.files').download(file)
-}
-
 export const isFileEncrypted = file => isEncrypted(file)
 
 export const formatDate = ({ f, lang, date }) => {
diff --git a/react/Viewer/helpers.spec.js b/react/Viewer/helpers.spec.js
index 410ddcf163..d347e54eff 100644
--- a/react/Viewer/helpers.spec.js
+++ b/react/Viewer/helpers.spec.js
@@ -1,11 +1,9 @@
-import { createMockClient } from 'cozy-client'
 import {
   KNOWN_DATE_METADATA_NAMES,
   KNOWN_INFORMATION_METADATA_NAMES
 } from 'cozy-client/dist/models/paper'
 
 import {
-  downloadFile,
   getCurrentModel,
   buildEditAttributePath,
   isEditableAttribute,
@@ -13,29 +11,6 @@ import {
 } from './helpers'
 
 describe('helpers', () => {
-  describe('download', () => {
-    const client = new createMockClient({})
-    const mockDownload = jest.fn()
-    const mockForceFileDownload = jest.fn()
-    client.collection = jest.fn(() => ({
-      download: mockDownload,
-      forceFileDownload: mockForceFileDownload
-    }))
-
-    it('should call download when file is not encrypted', async () => {
-      const file = { name: 'toto.txt' }
-
-      await downloadFile({ client, file })
-      expect(mockDownload).toHaveBeenCalledWith(file)
-    })
-
-    it('should call forceFileDownload when file is encrypted', async () => {
-      const file = { name: 'encrypted-toto.txt', encrypted: true }
-      const url = 'blob:http://thedecryptedtoto'
-      await downloadFile({ client, file, url })
-      expect(mockForceFileDownload).toHaveBeenCalledWith(url, file.name)
-    })
-  })
   describe('getCurrentModel', () => {
     const expected = 'information'
     it.each([