From b59bc5495a2565055f004fbf18b78d2eadc25690 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9o=20Poizat?= <hello@zatteo.com>
Date: Mon, 2 Dec 2024 15:03:58 +0100
Subject: [PATCH] test: Delete enzyme tests for deprecated components

---
 react/deprecated/ActionMenu/index.spec.jsx | 115 ---------------------
 react/deprecated/Alerter/alerter.spec.js   |  78 --------------
 react/deprecated/Modal/index.spec.jsx      |  70 -------------
 react/deprecated/ViewStack/index.spec.jsx  |  64 ------------
 4 files changed, 327 deletions(-)
 delete mode 100644 react/deprecated/ActionMenu/index.spec.jsx
 delete mode 100644 react/deprecated/Alerter/alerter.spec.js
 delete mode 100644 react/deprecated/Modal/index.spec.jsx
 delete mode 100644 react/deprecated/ViewStack/index.spec.jsx

diff --git a/react/deprecated/ActionMenu/index.spec.jsx b/react/deprecated/ActionMenu/index.spec.jsx
deleted file mode 100644
index 814c9aaa28..0000000000
--- a/react/deprecated/ActionMenu/index.spec.jsx
+++ /dev/null
@@ -1,115 +0,0 @@
-import { render } from '@testing-library/react'
-import { mount } from 'enzyme'
-import React from 'react'
-import { act } from 'react-dom/test-utils'
-
-import ActionMenu, { ActionMenuItem, ActionMenuRadio } from '.'
-import Icon from '../../Icon'
-import FileIcon from '../../Icons/File'
-import WarningIcon from '../../Icons/Warning'
-import { fixPopperTesting } from '../../Popper/testing'
-import Typography from '../../Typography'
-import { BreakpointsProvider } from '../../providers/Breakpoints'
-
-xdescribe('ActionMenu', () => {
-  fixPopperTesting()
-
-  // The update-not-wrapping-in-act warning is disabled for ActionMenuWrapper since
-  // we have not found how to remove the "update" happening when mounting the
-  // ActionMenu.
-  let originalConsoleError = console.error
-
-  beforeEach(() => {
-    // eslint-disable-next-line no-console
-    console.error = function (msg, arg) {
-      if (
-        msg.includes('An update to %s inside a test was not wrapped in act') &&
-        arg == 'ActionMenuWrapper'
-      ) {
-        return
-      } else {
-        return originalConsoleError.apply(this, arguments)
-      }
-    }
-  })
-
-  afterEach(() => {
-    // eslint-disable-next-line no-console
-    console.error = originalConsoleError
-  })
-
-  it('should support null children', async () => {
-    const comp = mount(
-      <BreakpointsProvider>
-        <ActionMenu onClose={jest.fn()}>
-          <ActionMenuItem>Item 1</ActionMenuItem>
-          {null}
-        </ActionMenu>
-      </BreakpointsProvider>
-    )
-    // Remove an update was not wrapped in act() warning
-    await act(async () => {})
-    expect(comp.find(ActionMenuItem).parent().getElement()).toMatchSnapshot()
-  })
-
-  it('should support auto-closing the menu', async () => {
-    const closeMenu = jest.fn()
-    const menuAction1 = jest.fn()
-    const menuAction2 = jest.fn()
-    const menuActionStoppingPropagation = e => {
-      e.stopPropagation()
-      menuAction2()
-    }
-
-    const comp = mount(
-      <BreakpointsProvider>
-        <ActionMenu onClose={closeMenu} autoclose>
-          <ActionMenuItem onClick={menuAction1}>Item 1</ActionMenuItem>
-          <ActionMenuItem onClick={menuActionStoppingPropagation}>
-            Item 2
-          </ActionMenuItem>
-        </ActionMenu>
-      </BreakpointsProvider>
-    )
-
-    await act(async () => {
-      comp.find(ActionMenuItem).at(1).simulate('click')
-    })
-    expect(menuAction2).toHaveBeenCalled()
-    expect(closeMenu).not.toHaveBeenCalled()
-
-    act(() => {
-      comp.find(ActionMenuItem).at(0).simulate('click')
-    })
-    expect(menuAction1).toHaveBeenCalled()
-    expect(closeMenu).toHaveBeenCalled()
-  })
-
-  it('should render as expected', async () => {
-    const { container } = render(
-      <BreakpointsProvider>
-        <ActionMenuItem
-          left={<Icon icon={FileIcon} />}
-          right={<Icon icon={WarningIcon} color="var(--errorColor)" />}
-          onClick={() => alert('click')}
-        >
-          Item 1 with onclick action
-        </ActionMenuItem>
-        <ActionMenuItem left={<Icon icon={FileIcon} />}>
-          Item 2 with dialog action
-        </ActionMenuItem>
-        <ActionMenuItem left={<ActionMenuRadio />}>Item 3</ActionMenuItem>
-        <ActionMenuItem left={<Icon icon={FileIcon} />}>
-          <Typography variant="body1" gutterBottom>
-            Item 4
-          </Typography>
-          <Typography variant="caption" color="textSecondary">
-            Descriptive text to elaborate on what item 3 does.
-          </Typography>
-        </ActionMenuItem>
-      </BreakpointsProvider>
-    )
-
-    expect(container).toMatchSnapshot()
-  })
-})
diff --git a/react/deprecated/Alerter/alerter.spec.js b/react/deprecated/Alerter/alerter.spec.js
deleted file mode 100644
index 33c6f6e3e6..0000000000
--- a/react/deprecated/Alerter/alerter.spec.js
+++ /dev/null
@@ -1,78 +0,0 @@
-'use strict'
-/* eslint-env jest */
-
-import { shallow } from 'enzyme'
-import React from 'react'
-
-import Alerter from '.'
-import Alert from './Alert'
-import Button from '../Button'
-
-describe('Alerter component', () => {
-  beforeEach(() => {
-    Alerter.reset()
-  })
-  //
-  ;['info', 'success', 'error'].forEach(type => {
-    it(`renders correctly an ${type} alert`, () => {
-      const wrapper = shallow(<Alerter />)
-      Alerter[type](`Test ${type} alert`)
-      expect(wrapper.find(Alert).dive().getElement()).toMatchSnapshot()
-    })
-  })
-
-  it('should not render too much alerts', () => {
-    const wrapper = shallow(<Alerter />)
-    Alerter.info(`Test 1`)
-    Alerter.info(`Test 2`)
-    Alerter.info(`Test 3`)
-    expect(wrapper.find(Alert).length).toBe(3)
-  })
-
-  it('renders button if buttonText provided', () => {
-    const wrapper = shallow(<Alerter />)
-    Alerter.info(`Test alert with button`, {
-      buttonText: 'BTN'
-    })
-    expect(wrapper.find(Alert).dive().getElement()).toMatchSnapshot()
-  })
-
-  it('handles dismiss provided to buttonAction', () => {
-    const alerterWrapper = shallow(<Alerter />)
-    Alerter.info(`Test alert with button`, {
-      buttonText: 'BTN',
-      buttonAction: dismiss => {
-        console.log('DISMISS')
-        dismiss()
-      },
-      duration: 20000
-    })
-    const alertWrapper = alerterWrapper.find(Alert)
-    const alert = alertWrapper.dive()
-    expect(alert.getElement()).toMatchSnapshot()
-    alert.instance().base = document.createElement('div')
-    // we have to wait the same delay as in the Alerter didMount
-    setTimeout(() => {
-      expect(alert.state('hidden')).toBe(false)
-      alert.children().find(Button).simulate('click')
-      expect(alert.state('hidden')).toBe(true)
-    }, 20)
-  })
-
-  it('handles programmatic removal', () => {
-    const wrapper = shallow(<Alerter />)
-    const notif = Alerter.info(`Test alert with button`, {
-      duration: 20000
-    })
-    Alerter.info(`Test another alert`, {
-      duration: 20000
-    })
-    expect(wrapper.find(Alert).length).toBe(2)
-    Alerter.removeNotification(notif)
-    expect(wrapper.find(Alert).length).toBe(1)
-
-    // Nothing should happen if we try to remove a non existing notification
-    Alerter.removeNotification(notif)
-    expect(wrapper.find(Alert).length).toBe(1)
-  })
-})
diff --git a/react/deprecated/Modal/index.spec.jsx b/react/deprecated/Modal/index.spec.jsx
deleted file mode 100644
index b756959a39..0000000000
--- a/react/deprecated/Modal/index.spec.jsx
+++ /dev/null
@@ -1,70 +0,0 @@
-import { mount } from 'enzyme'
-import React, { useState } from 'react'
-import { act } from 'react-dom/test-utils'
-
-import Modal, { BODY_CLASS } from '.'
-import { BreakpointsProvider } from '../../providers/Breakpoints'
-
-describe('Modal', () => {
-  const Example = () => {
-    const [showModal, setShowModal] = useState(false)
-    const [showModal2, setShowModal2] = useState(false)
-    return (
-      <BreakpointsProvider>
-        {showModal ? <Modal title="example 1">1</Modal> : null}
-        {showModal2 ? <Modal title="example 2">2</Modal> : null}
-        <button onClick={() => setShowModal(true)} />
-        <button onClick={() => setShowModal2(true)} />
-        <button onClick={() => setShowModal2(false)} />
-        <button onClick={() => setShowModal(false)} />
-      </BreakpointsProvider>
-    )
-  }
-
-  const clickNthButton = (root, n) =>
-    root.find('button').at(n).props().onClick()
-
-  const mountFirstModal = root => clickNthButton(root, 0)
-  const mountSecondModal = root => clickNthButton(root, 1)
-  const unmountSecondModal = root => clickNthButton(root, 2)
-  const unmountFirstModal = root => clickNthButton(root, 3)
-
-  const hasModalBodyClass = () => document.body.classList.contains(BODY_CLASS)
-
-  afterEach(() => {
-    document.body.classList.remove(BODY_CLASS)
-  })
-
-  it('should apply a class to the body when mounted', () => {
-    const root = mount(<Example />)
-    expect(hasModalBodyClass()).toBe(false)
-    act(() => {
-      mountFirstModal(root)
-    })
-    expect(hasModalBodyClass()).toBe(true)
-    act(() => {
-      unmountFirstModal(root)
-    })
-    expect(hasModalBodyClass()).toBe(false)
-  })
-
-  it('should not remove the class if two modals were mounted and the second one is removed', () => {
-    const root = mount(<Example />)
-    expect(hasModalBodyClass()).toBe(false)
-    act(() => {
-      mountFirstModal(root)
-    })
-    expect(hasModalBodyClass()).toBe(true)
-    act(() => {
-      mountSecondModal(root)
-    })
-    act(() => {
-      unmountSecondModal(root)
-    })
-    expect(hasModalBodyClass()).toBe(true)
-    act(() => {
-      unmountFirstModal(root)
-    })
-    expect(hasModalBodyClass()).toBe(false)
-  })
-})
diff --git a/react/deprecated/ViewStack/index.spec.jsx b/react/deprecated/ViewStack/index.spec.jsx
deleted file mode 100644
index 325e3ed32b..0000000000
--- a/react/deprecated/ViewStack/index.spec.jsx
+++ /dev/null
@@ -1,64 +0,0 @@
-import { mount } from 'enzyme'
-import React from 'react'
-import { act } from 'react-dom/test-utils'
-import SwipeableViews from 'react-swipeable-views'
-
-import ViewStack from '.'
-import { Slide } from './example'
-import Button from '../Button'
-
-const findButtonWithLabel = (root, label) =>
-  root.findWhere(n => n.type() == Button && n.props().label === label)
-
-describe('ViewStack', () => {
-  beforeEach(() => {
-    const originalError = console.error.bind(console)
-
-    // Ignore act's warning, since act does not support async logic and we have
-    // a sleep when popping to wait for the animation
-    jest.spyOn(console, 'error').mockImplementation(function (message) {
-      if (
-        !message.includes(
-          'An update to %s inside a test was not wrapped in act'
-        )
-      ) {
-        originalError.apply(this, arguments)
-      }
-    })
-  })
-
-  afterEach(() => {
-    jest.restoreAllMocks()
-  })
-
-  it('should push / pop views', async () => {
-    const root = mount(
-      <ViewStack>
-        <Slide number={1} />
-      </ViewStack>
-    )
-    expect(root.find(Slide).props().number).toBe(1)
-    act(() => {
-      findButtonWithLabel(root, 'stack').props().onClick()
-    })
-    root.update()
-
-    const swiperProps = root.find(SwipeableViews).props()
-    expect(swiperProps.children.length).toBe(2)
-    expect(swiperProps.index).toBe(1)
-
-    let prom
-    act(() => {
-      prom = findButtonWithLabel(root, 'pop').props().onClick()
-    })
-    root.update()
-    const swiperProps2 = root.find(SwipeableViews).props()
-    expect(swiperProps2.index).toBe(0)
-    expect(swiperProps2.children.length).toBe(2) // waiting for animation
-
-    await prom
-    root.update()
-    const swiperProps3 = root.find(SwipeableViews).props()
-    expect(swiperProps3.children.length).toBe(1)
-  })
-})