From 866de145ecd388991257dc6e208c1d97faea8657 Mon Sep 17 00:00:00 2001 From: Ldoppea Date: Fri, 19 Jan 2024 15:01:48 +0100 Subject: [PATCH] fix: Force android tools version on CI when signing APK Since January 8 the `ubuntu-latest` image excludes Android SDKs prior to version 31 By default the `r0adkll/sign-android-release` package uses Android SDK 29. So the build would fail In order to fix that, we can set the `BUILD_TOOLS_VERSION` env variable to define which version `r0adkll/sign-android-release` should use Related doc: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md Related issue: r0adkll/sign-android-release#84 --- .github/workflows/build-android-dev.yml | 4 ++++ .github/workflows/build-android-prod.yml | 2 ++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/build-android-dev.yml b/.github/workflows/build-android-dev.yml index c42d20309..1e1de7af1 100644 --- a/.github/workflows/build-android-dev.yml +++ b/.github/workflows/build-android-dev.yml @@ -109,6 +109,8 @@ jobs: alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }} keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }} keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }} + env: + BUILD_TOOLS_VERSION: "33.0.0" - name: Upload Dev artifact to GitHub uses: actions/upload-artifact@v3 @@ -126,6 +128,8 @@ jobs: alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }} keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }} keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }} + env: + BUILD_TOOLS_VERSION: "33.0.0" - name: Upload Prod artifact to GitHub uses: actions/upload-artifact@v3 diff --git a/.github/workflows/build-android-prod.yml b/.github/workflows/build-android-prod.yml index 5f4d56fdf..71fd23d23 100644 --- a/.github/workflows/build-android-prod.yml +++ b/.github/workflows/build-android-prod.yml @@ -95,6 +95,8 @@ jobs: alias: ${{ secrets[format('{0}_ANDROID_ALIAS', inputs.brand)] }} keyStorePassword: ${{ secrets[format('{0}_ANDROID_KEY_STORE_PASSWORD', inputs.brand)] }} keyPassword: ${{ secrets[format('{0}_ANDROID_KEY_PASSWORD', inputs.brand)] }} + env: + BUILD_TOOLS_VERSION: "33.0.0" - name: Upload AAB artifact to GitHub uses: actions/upload-artifact@v3