From 88c6e1b0911f9a3d90909941413aaf68ae0c385a Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Mon, 28 Oct 2024 16:31:05 +0100
Subject: [PATCH 1/7] feat: Change wording of group manage button

f
---
 src/components/GroupsSelect/GroupsSelect.spec.jsx | 8 ++++----
 src/locales/de.json                               | 2 +-
 src/locales/en.json                               | 2 +-
 src/locales/es.json                               | 2 +-
 src/locales/fr.json                               | 2 +-
 src/locales/nl_NL.json                            | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/components/GroupsSelect/GroupsSelect.spec.jsx b/src/components/GroupsSelect/GroupsSelect.spec.jsx
index 394fca773..68126167b 100644
--- a/src/components/GroupsSelect/GroupsSelect.spec.jsx
+++ b/src/components/GroupsSelect/GroupsSelect.spec.jsx
@@ -34,7 +34,7 @@ describe('GroupsSelect', () => {
     setup()
 
     act(() => {
-      fireEvent.click(screen.getByText('Manage groups'))
+      fireEvent.click(screen.getByText('Groups'))
     })
 
     for (const group of groups) {
@@ -47,7 +47,7 @@ describe('GroupsSelect', () => {
     setup()
 
     act(() => {
-      fireEvent.click(screen.getByText('Manage groups'))
+      fireEvent.click(screen.getByText('Groups'))
     })
 
     act(() => {
@@ -98,7 +98,7 @@ describe('GroupsSelect', () => {
     setup()
 
     act(() => {
-      fireEvent.click(screen.getByText('Manage groups'))
+      fireEvent.click(screen.getByText('Groups'))
     })
 
     act(() => {
@@ -150,7 +150,7 @@ describe('GroupsSelect', () => {
 
     act(() => {
       // it should replace the field by input with group name as value
-      fireEvent.click(screen.getByText('Manage groups'))
+      fireEvent.click(screen.getByText('Groups'))
     })
 
     act(() => {
diff --git a/src/locales/de.json b/src/locales/de.json
index 439500caa..53a830171 100644
--- a/src/locales/de.json
+++ b/src/locales/de.json
@@ -107,7 +107,7 @@
   },
   "groups": {
     "none": "Es existiert keine Gruppe.",
-    "manage": "Verwalte Gruppen",
+    "manage": "Gruppen",
     "create": "Erstelle eine Gruppe",
     "created": {
       "success": "Die Gruppe wurde erfolgreich erstellt.",
diff --git a/src/locales/en.json b/src/locales/en.json
index 926b09947..8dc2b0f9b 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -143,7 +143,7 @@
   },
   "groups": {
     "none": "There is no existing group.",
-    "manage": "Manage groups",
+    "manage": "Groups",
     "create": "Create a group",
     "created": {
       "success": "The group has been created correctly.",
diff --git a/src/locales/es.json b/src/locales/es.json
index cc83e8f56..495df1520 100644
--- a/src/locales/es.json
+++ b/src/locales/es.json
@@ -126,7 +126,7 @@
   },
   "groups": {
     "none": "No existe un grupo.",
-    "manage": "Administrar grupos",
+    "manage": "Grupos",
     "create": "Crear un grupo",
     "created": {
       "success": "El grupo ha sido creado correctamente.",
diff --git a/src/locales/fr.json b/src/locales/fr.json
index eba3af0ef..e8f7bb54a 100644
--- a/src/locales/fr.json
+++ b/src/locales/fr.json
@@ -143,7 +143,7 @@
   },
   "groups": {
     "none": "Il n'y a pas encore de groupes.",
-    "manage": "Gérer les groupes",
+    "manage": "Groupes",
     "create": "Créer un groupe",
     "created": {
       "success": "Le groupe a bien été créé.",
diff --git a/src/locales/nl_NL.json b/src/locales/nl_NL.json
index ee7ca17f3..fe6e75a06 100644
--- a/src/locales/nl_NL.json
+++ b/src/locales/nl_NL.json
@@ -107,7 +107,7 @@
   },
   "groups": {
     "none": "Er is nog geen groep.",
-    "manage": "Groepen beheren",
+    "manage": "Groepen",
     "create": "Groep samenstellen",
     "created": {
       "success": "De groep is samengesteld.",

From c11f8c63ef77808d051cc15ef7b5225d3bf33997 Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Mon, 28 Oct 2024 16:35:51 +0100
Subject: [PATCH 2/7] refactor: Remove create and update Contact helpers

These helpers simply wraps around an existing methods.
---
 src/components/Intents/CreateContact.jsx        | 4 ++--
 src/components/Modals/ContactFormModal.spec.jsx | 2 --
 src/connections/allContacts.js                  | 7 +------
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/components/Intents/CreateContact.jsx b/src/components/Intents/CreateContact.jsx
index f316d234f..f5fd68b21 100644
--- a/src/components/Intents/CreateContact.jsx
+++ b/src/components/Intents/CreateContact.jsx
@@ -1,13 +1,13 @@
 import flow from 'lodash/flow'
 import PropTypes from 'prop-types'
 import React from 'react'
+import { DOCTYPE_CONTACTS } from 'src/helpers/doctypes'
 
 import { withClient } from 'cozy-client'
 import IntentHeader from 'cozy-ui/transpiled/react/IntentHeader'
 import { translate } from 'cozy-ui/transpiled/react/providers/I18n'
 
 import IntentMain from './IntentMain'
-import { createContact as createContactWithClient } from '../../connections/allContacts'
 import ContactForm from '../ContactCard/ContactForm'
 
 const CreateContact = ({ client, data, onTerminate, onError, onCancel }) => {
@@ -15,7 +15,7 @@ const CreateContact = ({ client, data, onTerminate, onError, onCancel }) => {
     try {
       const me = !!data.me
       if (me) contact.metadata.me = true
-      const resp = await createContactWithClient(client, contact)
+      const resp = await client.create(DOCTYPE_CONTACTS, contact)
       onTerminate(resp.data)
     } catch (e) {
       onError('Could not create contact')
diff --git a/src/components/Modals/ContactFormModal.spec.jsx b/src/components/Modals/ContactFormModal.spec.jsx
index 42d7f0f33..6338613c3 100644
--- a/src/components/Modals/ContactFormModal.spec.jsx
+++ b/src/components/Modals/ContactFormModal.spec.jsx
@@ -9,8 +9,6 @@ import { createOrUpdateContact } from '../../connections/allContacts'
 import AppLike from '../../tests/Applike'
 
 jest.mock('../../connections/allContacts', () => ({
-  createContact: jest.fn().mockResolvedValue({ data: 'created' }),
-  updateContact: jest.fn().mockResolvedValue({ data: 'updated' }),
   createOrUpdateContact: jest.fn()
 }))
 jest.mock('cozy-client/dist/hooks', () => ({
diff --git a/src/connections/allContacts.js b/src/connections/allContacts.js
index 11b2285f6..cc02cabf1 100644
--- a/src/connections/allContacts.js
+++ b/src/connections/allContacts.js
@@ -38,11 +38,6 @@ export const importContact = async (client, attributes) => {
   return client.create(DOCTYPE_CONTACTS, attributes, null)
 }
 
-export const createContact = (client, attributes) =>
-  client.create(DOCTYPE_CONTACTS, attributes)
-
-export const updateContact = (client, contact) => client.save(contact)
-
 const isContactSynced = contact => {
   return Object.keys(contact.cozyMetadata?.sync || {}).length > 0
 }
@@ -88,7 +83,7 @@ export const createOrUpdateContact = async ({
   formData,
   selectedGroup
 }) => {
-  const createOrUpdate = isUpdated ? updateContact : createContact
+  const createOrUpdate = isUpdated ? client.save : client.create
   let updatedContact = merge({}, formData)
 
   if (hasSelectedGroup(selectedGroup)) {

From e88c347480d57f64bf8e5382ebc510fe850a061e Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Mon, 28 Oct 2024 16:37:15 +0100
Subject: [PATCH 3/7] feat: Add favorite button

---
 src/components/Modals/ContactInfoTitle.jsx | 35 +++++++++++++++++++++-
 src/connections/allContacts.js             | 11 +++++--
 2 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/src/components/Modals/ContactInfoTitle.jsx b/src/components/Modals/ContactInfoTitle.jsx
index 10ab1128d..5a5f15c83 100644
--- a/src/components/Modals/ContactInfoTitle.jsx
+++ b/src/components/Modals/ContactInfoTitle.jsx
@@ -1,17 +1,22 @@
 import get from 'lodash/get'
+import throttle from 'lodash/throttle'
 import PropTypes from 'prop-types'
-import React from 'react'
+import React, { useCallback } from 'react'
 import { useNavigate } from 'react-router-dom'
 
+import { useClient } from 'cozy-client'
 import minilog from 'cozy-minilog'
 import Button from 'cozy-ui/transpiled/react/Buttons'
 import Grid from 'cozy-ui/transpiled/react/Grid'
 import Icon from 'cozy-ui/transpiled/react/Icon'
 import RenameIcon from 'cozy-ui/transpiled/react/Icons/Rename'
+import StarIcon from 'cozy-ui/transpiled/react/Icons/Star'
+import StarOutlineIcon from 'cozy-ui/transpiled/react/Icons/StarOutline'
 import TrashIcon from 'cozy-ui/transpiled/react/Icons/Trash'
 import { useAlert } from 'cozy-ui/transpiled/react/providers/Alert'
 import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n'
 
+import { updateContact } from '../../connections/allContacts'
 import { updateContactGroups } from '../../helpers/groups'
 import ContactIdentity from '../ContactCard/ContactIdentity'
 import { fullContactPropTypes } from '../ContactPropTypes'
@@ -39,6 +44,7 @@ const ContactInfoTitle = ({ contact, allGroups }) => {
   const navigate = useNavigate()
   const { t } = useI18n()
   const { showAlert } = useAlert()
+  const client = useClient()
 
   const handleChange = async nextGroups => {
     try {
@@ -53,6 +59,23 @@ const ContactInfoTitle = ({ contact, allGroups }) => {
     await contact.groups.addById(createdGroup._id)
   }
 
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  const throttledUpdateContact = useCallback(throttle(updateContact, 500), [])
+
+  const handleFavorite = () => {
+    throttledUpdateContact({
+      client,
+      contact,
+      attributes: {
+        cozyMetadata: {
+          favorite: !contact.cozyMetadata?.favorite
+        }
+      }
+    })
+  }
+  const isFavorite = contact.cozyMetadata?.favorite ?? false
+  const favoriteIcon = isFavorite ? StarIcon : StarOutlineIcon
+
   const handleValue = get(contact, 'relationships.groups.data', [])
 
   return (
@@ -74,6 +97,16 @@ const ContactInfoTitle = ({ contact, allGroups }) => {
             menuPosition="fixed"
           />
         </Grid>
+        <Grid item>
+          <Button
+            className="u-miw-auto"
+            variant="secondary"
+            label={<Icon icon={favoriteIcon} size={12} />}
+            size="small"
+            onClick={handleFavorite}
+            aria-label={t('edit')}
+          />
+        </Grid>
         <Grid item>
           <Button
             className="u-miw-auto"
diff --git a/src/connections/allContacts.js b/src/connections/allContacts.js
index cc02cabf1..921faa402 100644
--- a/src/connections/allContacts.js
+++ b/src/connections/allContacts.js
@@ -38,6 +38,11 @@ export const importContact = async (client, attributes) => {
   return client.create(DOCTYPE_CONTACTS, attributes, null)
 }
 
+export const updateContact = ({ client, contact, attributes }) => {
+  const updatedContact = mergeContact(contact, attributes)
+  return client.save(updatedContact)
+}
+
 const isContactSynced = contact => {
   return Object.keys(contact.cozyMetadata?.sync || {}).length > 0
 }
@@ -83,14 +88,14 @@ export const createOrUpdateContact = async ({
   formData,
   selectedGroup
 }) => {
-  const createOrUpdate = isUpdated ? client.save : client.create
   let updatedContact = merge({}, formData)
 
   if (hasSelectedGroup(selectedGroup)) {
     updatedContact = addGroupToContact(updatedContact, selectedGroup)
   }
-
-  return createOrUpdate(client, updatedContact)
+  return isUpdated
+    ? client.save(updatedContact)
+    : client.create(DOCTYPE_CONTACTS, updatedContact)
 }
 
 /**

From 2503c68261d394fbef67138760bc1c039879f464 Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Tue, 29 Oct 2024 13:44:28 +0100
Subject: [PATCH 4/7] feat: Upgrade cozy-ui to 112.0.0

---
 package.json | 2 +-
 yarn.lock    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/package.json b/package.json
index 137f92672..3cac715e1 100644
--- a/package.json
+++ b/package.json
@@ -87,7 +87,7 @@
     "cozy-minilog": "^3.3.1",
     "cozy-realtime": "^5.0.0",
     "cozy-sharing": "^16.0.0",
-    "cozy-ui": "^111.12.0",
+    "cozy-ui": "^112.0.0",
     "cozy-vcard": "^0.2.18",
     "final-form": "4.20.9",
     "final-form-arrays": "3.1.0",
diff --git a/yarn.lock b/yarn.lock
index 72e105971..f2a5dd2ec 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -5329,10 +5329,10 @@ cozy-stack-client@^48.16.0:
     mime "^2.4.0"
     qs "^6.7.0"
 
-cozy-ui@^111.12.0:
-  version "111.12.0"
-  resolved "https://registry.yarnpkg.com/cozy-ui/-/cozy-ui-111.12.0.tgz#c0db5fa110037ab0c3d364a55adf504091b4fb98"
-  integrity sha512-JmQUA9ysnJWsSf4eaVqdaMYV8IgmzNVOlVLwMSVCRzs5lerRnVZZ3KDBW78pyrx4Au6k0ijnAct3su5hUOTldA==
+cozy-ui@^112.0.0:
+  version "112.0.0"
+  resolved "https://registry.yarnpkg.com/cozy-ui/-/cozy-ui-112.0.0.tgz#0c6f41ab5e8207617afa463cdd96686a4f855f57"
+  integrity sha512-BflsHZMnKzYSSiQMARFCH5GuzQsXBU8wN2NG/qkRtFVmrLjLK0b2xZLDqxU3957RSqE486yGYqSTxVcYGjIHUA==
   dependencies:
     "@babel/runtime" "^7.3.4"
     "@material-ui/core" "4.12.3"

From e9b5f1067473108f38be2d4c446032fe0d9525e4 Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Tue, 29 Oct 2024 13:47:14 +0100
Subject: [PATCH 5/7] feat: Replace deprecated SelectionBar by ActionBar

---
 src/components/Actions/helpers.js             | 15 --------
 src/components/Actions/helpers.spec.js        | 34 -------------------
 src/components/Actions/index.js               |  2 --
 src/components/Actions/selectAll.js           |  7 ++--
 src/components/Actions/trash.jsx              |  5 ++-
 .../layout/ContactsSelectionBar.jsx           | 13 +++----
 6 files changed, 14 insertions(+), 62 deletions(-)
 delete mode 100644 src/components/Actions/helpers.js
 delete mode 100644 src/components/Actions/helpers.spec.js
 delete mode 100644 src/components/Actions/index.js

diff --git a/src/components/Actions/helpers.js b/src/components/Actions/helpers.js
deleted file mode 100644
index 12e0de041..000000000
--- a/src/components/Actions/helpers.js
+++ /dev/null
@@ -1,15 +0,0 @@
-/**
- * Make object of actions for SelectionBar component
- *
- * @param {Array} actions - Array of actions
- * @param {Object} options - Options for actions
- * @returns {Object} - Object with actions
- */
-export const makeActions = (actions = [], options = {}) => {
-  return actions.reduce((acc, action) => {
-    const actionMenu = action(options)
-    const name = actionMenu.name || action.name
-
-    return { ...acc, [name]: actionMenu }
-  }, {})
-}
diff --git a/src/components/Actions/helpers.spec.js b/src/components/Actions/helpers.spec.js
deleted file mode 100644
index dc5086b48..000000000
--- a/src/components/Actions/helpers.spec.js
+++ /dev/null
@@ -1,34 +0,0 @@
-import { makeActions } from './helpers'
-
-describe('makeActions', () => {
-  it('should have empty actions object', () => {
-    const actions = makeActions()
-
-    expect(actions).toStrictEqual({})
-  })
-
-  it('should have object with key named with name property of the object returned by the function and value is the full object returned by the function', () => {
-    const mockFuncActionWithName = jest.fn(() => ({
-      name: 'mockFuncActionWithName name'
-    }))
-
-    const actions = makeActions([mockFuncActionWithName])
-
-    expect(actions).toStrictEqual({
-      'mockFuncActionWithName name': {
-        name: 'mockFuncActionWithName name'
-      }
-    })
-  })
-
-  it('should have object with key named with name of function passed and value is the full object returned by the function', () => {
-    const mockFuncActionWithoutName = jest.fn(() => ({
-      propA: 0,
-      propB: 1
-    }))
-
-    const actions = makeActions([mockFuncActionWithoutName])
-
-    expect(actions).toStrictEqual({ mockConstructor: { propA: 0, propB: 1 } })
-  })
-})
diff --git a/src/components/Actions/index.js b/src/components/Actions/index.js
deleted file mode 100644
index e46a77c18..000000000
--- a/src/components/Actions/index.js
+++ /dev/null
@@ -1,2 +0,0 @@
-export { trash } from './trash'
-export { selectAll } from './selectAll'
diff --git a/src/components/Actions/selectAll.js b/src/components/Actions/selectAll.js
index d3797c8f5..785f650ca 100644
--- a/src/components/Actions/selectAll.js
+++ b/src/components/Actions/selectAll.js
@@ -7,9 +7,12 @@
  * @param {Function} options.selectAll - Function to select all contacts
  * @returns {Object} - Object with action
  */
-export const selectAll = ({ contactsDisplayed, selection, selectAll }) => {
+export const selectAll = ({ contactsDisplayed, selection, selectAll, t }) => {
+  const label = t('SelectionBar.select_all_action')
+
   return {
-    name: 'select_all_action',
+    name: 'selectAll',
+    label,
     icon: 'select-all',
     action: () => {
       const isAllContactsSelected =
diff --git a/src/components/Actions/trash.jsx b/src/components/Actions/trash.jsx
index 95966b4df..0e90b9baf 100644
--- a/src/components/Actions/trash.jsx
+++ b/src/components/Actions/trash.jsx
@@ -25,8 +25,11 @@ export const trash = ({
   client,
   t
 }) => {
+  const label = t('SelectionBar.trash_action')
+
   return {
-    name: 'trash_action',
+    name: 'trash',
+    label,
     icon: 'trash',
     action: () => {
       const hasConnectedAccounts = contact =>
diff --git a/src/components/layout/ContactsSelectionBar.jsx b/src/components/layout/ContactsSelectionBar.jsx
index 330863ab9..a05209305 100644
--- a/src/components/layout/ContactsSelectionBar.jsx
+++ b/src/components/layout/ContactsSelectionBar.jsx
@@ -3,11 +3,12 @@ import PropTypes from 'prop-types'
 import React, { useContext } from 'react'
 
 import { useClient } from 'cozy-client'
-import SelectionBar from 'cozy-ui/transpiled/react/SelectionBar'
+import ActionsBar from 'cozy-ui/transpiled/react/ActionsBar'
+import { makeActions } from 'cozy-ui/transpiled/react/ActionsMenu/Actions'
 import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n'
 
-import { trash as trashAction, selectAll as selectAllAction } from '../Actions'
-import { makeActions } from '../Actions/helpers'
+import { selectAll as selectAllAction } from '../Actions/selectAll'
+import { trash as trashAction } from '../Actions/trash'
 import ContactsDiplayedContext from '../Contexts/ContactsDiplayed'
 import withModalContainer from '../HOCs/withModal'
 import withSelection from '../Selection/selectionContainer'
@@ -35,11 +36,7 @@ const ContactsSelectionBar = ({
   })
 
   return selection.length > 0 ? (
-    <SelectionBar
-      selected={selection}
-      hideSelectionBar={clearSelection}
-      actions={actions}
-    />
+    <ActionsBar docs={selection} actions={actions} />
   ) : null
 }
 

From b8376ac52d1da3d3276542d2a6dbb3a34f3ef7fc Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Tue, 29 Oct 2024 13:49:15 +0100
Subject: [PATCH 6/7] feat: Add favorite action

This action simply adds a contact as a favorite.
Used in the Cozy browser extension.
---
 src/components/Actions/favorite.js      | 50 +++++++++++++++
 src/components/Actions/favorite.spec.js | 85 +++++++++++++++++++++++++
 src/locales/en.json                     |  4 +-
 src/locales/fr.json                     |  4 +-
 4 files changed, 141 insertions(+), 2 deletions(-)
 create mode 100644 src/components/Actions/favorite.js
 create mode 100644 src/components/Actions/favorite.spec.js

diff --git a/src/components/Actions/favorite.js b/src/components/Actions/favorite.js
new file mode 100644
index 000000000..0761f4dc8
--- /dev/null
+++ b/src/components/Actions/favorite.js
@@ -0,0 +1,50 @@
+import minilog from 'cozy-minilog'
+
+import { updateContact } from '../../connections/allContacts'
+
+const log = minilog('connections/allContacts')
+
+/**
+ * Action to favorite a contact
+ * @param  {object} options.client - CozyClient instance
+ * @param  {array} options.selection - Array of selected contacts
+ * @param  {object} options.t - Translation function
+ */
+export const favorite = ({ client, selection, clearSelection, t }) => {
+  const noFavoriteSelected = selection.filter(
+    contact => !contact.cozyMetadata?.favorite
+  )
+  const isAllFavorite = noFavoriteSelected.length === 0
+  const icon = isAllFavorite ? 'star' : 'star-outline'
+  const label = isAllFavorite
+    ? t('SelectionBar.remove_favorite')
+    : t('SelectionBar.add_favorite')
+
+  return {
+    name: 'favorite',
+    label,
+    icon,
+    action: async () => {
+      const contactToUpdate = isAllFavorite ? selection : noFavoriteSelected
+      const favorite = isAllFavorite ? false : true
+
+      try {
+        await Promise.all(
+          contactToUpdate.map(contact =>
+            updateContact({
+              client,
+              contact,
+              attributes: {
+                cozyMetadata: { favorite }
+              }
+            })
+          )
+        )
+      } catch (error) {
+        log.error('Error updating contact', error)
+      } finally {
+        clearSelection()
+      }
+    }
+  }
+}
diff --git a/src/components/Actions/favorite.spec.js b/src/components/Actions/favorite.spec.js
new file mode 100644
index 000000000..592c41c1f
--- /dev/null
+++ b/src/components/Actions/favorite.spec.js
@@ -0,0 +1,85 @@
+import { favorite } from './favorite'
+import { updateContact } from '../../connections/allContacts'
+
+jest.mock('../../connections/allContacts', () => ({
+  updateContact: jest.fn()
+}))
+
+describe('favorite', () => {
+  const clearSelection = jest.fn()
+
+  const favoriteSelection = [
+    {
+      _id: '000',
+      cozyMetadata: {
+        favorite: true
+      }
+    },
+    {
+      _id: '001',
+      cozyMetadata: {
+        favorite: true
+      }
+    }
+  ]
+  const unfavoriteSelection = [
+    {
+      _id: '100',
+      cozyMetadata: {
+        favorite: false
+      }
+    },
+    {
+      _id: '101',
+      cozyMetadata: {
+        favorite: false
+      }
+    }
+  ]
+  const mixedSelection = [favoriteSelection[0], unfavoriteSelection[0]]
+
+  it('should return action with "add_favorite" label & "star-outline" icon', async () => {
+    const action = favorite({
+      selection: unfavoriteSelection,
+      clearSelection,
+      t: jest.fn(k => k)
+    })
+
+    expect(action.label).toBe('SelectionBar.add_favorite')
+    expect(action.icon).toBe('star-outline')
+
+    const action2 = favorite({
+      selection: mixedSelection,
+      clearSelection,
+      t: jest.fn(k => k)
+    })
+
+    expect(action2.label).toBe('SelectionBar.add_favorite')
+    expect(action2.icon).toBe('star-outline')
+  })
+
+  it('should return action with "remove_favorite" label & "star" icon', async () => {
+    const action = favorite({
+      selection: favoriteSelection,
+      clearSelection,
+      t: jest.fn(k => k)
+    })
+
+    expect(action.label).toBe('SelectionBar.remove_favorite')
+    expect(action.icon).toBe('star')
+  })
+
+  it('Should only update not favorite contacts', async () => {
+    const action = favorite({
+      selection: mixedSelection,
+      clearSelection,
+      t: jest.fn(k => k)
+    })
+
+    expect(action.label).toBe('SelectionBar.add_favorite')
+    expect(action.icon).toBe('star-outline')
+    await action.action()
+    expect(updateContact).toHaveBeenCalledTimes(1)
+    expect(clearSelection).toHaveBeenCalledTimes(1)
+  })
+})
diff --git a/src/locales/en.json b/src/locales/en.json
index 8dc2b0f9b..2646d315b 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -139,7 +139,9 @@
     "close": "Close",
     "selected_count": "contact selected |||| contacts selected",
     "trash_action": "delete",
-    "select_all_action": "Select all"
+    "select_all_action": "Select all",
+    "add_favorite": "Add to favorites",
+    "remove_favorite": "Remove favorites"
   },
   "groups": {
     "none": "There is no existing group.",
diff --git a/src/locales/fr.json b/src/locales/fr.json
index e8f7bb54a..4a9746aeb 100644
--- a/src/locales/fr.json
+++ b/src/locales/fr.json
@@ -139,7 +139,9 @@
     "close": "Fermer",
     "selected_count": "contact sélectionné |||| contacts sélectionnés",
     "trash_action": "Supprimer",
-    "select_all_action": "Sélectionner tout"
+    "select_all_action": "Sélectionner tout",
+    "add_favorite": "Ajouter aux favoris",
+    "remove_favorite": "Retirer des favoris"
   },
   "groups": {
     "none": "Il n'y a pas encore de groupes.",

From 07f08a700536704ea5a84d25c5aa63c0002decec Mon Sep 17 00:00:00 2001
From: AlexisG <merkkur39@gmail.com>
Date: Tue, 29 Oct 2024 13:51:35 +0100
Subject: [PATCH 7/7] feat: Add favorite action to ContactsSelectionBar

---
 src/components/layout/ContactsSelectionBar.jsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/components/layout/ContactsSelectionBar.jsx b/src/components/layout/ContactsSelectionBar.jsx
index a05209305..dd1895df7 100644
--- a/src/components/layout/ContactsSelectionBar.jsx
+++ b/src/components/layout/ContactsSelectionBar.jsx
@@ -7,6 +7,7 @@ import ActionsBar from 'cozy-ui/transpiled/react/ActionsBar'
 import { makeActions } from 'cozy-ui/transpiled/react/ActionsMenu/Actions'
 import { useI18n } from 'cozy-ui/transpiled/react/providers/I18n'
 
+import { favorite as favoriteAction } from '../Actions/favorite'
 import { selectAll as selectAllAction } from '../Actions/selectAll'
 import { trash as trashAction } from '../Actions/trash'
 import ContactsDiplayedContext from '../Contexts/ContactsDiplayed'
@@ -24,7 +25,7 @@ const ContactsSelectionBar = ({
   const { t } = useI18n()
   const { contactsDisplayed } = useContext(ContactsDiplayedContext)
 
-  const actions = makeActions([selectAllAction, trashAction], {
+  const actions = makeActions([selectAllAction, trashAction, favoriteAction], {
     contactsDisplayed,
     selectAll,
     selection,