Fix connection timeout #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram-vdberg
force-pushed
the
Fix-Connection-Timeout
branch
from
e33059a to
83e2b0b
Compare
fhenneke
approved these changes
Dec 13, 2024
| @@ -58,10 +70,14 @@ def get_solver_rewards( | |||
|
|
|||
| # Here, we use the convention that we run the prod query for the first connection | |||
| # and the barn query to all other connections | |||
| log.info("Setting tcp_keepalives_idle to 900 for prod connection") | |||
| self.connections[0].execute(text("SET tcp_keepalives_idle = 900;")) | |||
There was a problem hiding this comment.
I would probably introduce a constant for this value.
| results.append( | ||
| self.exec_query(query=batch_reward_query_prod, engine=self.connections[0]) | ||
| ) | ||
| for engine in self.connections[1:]: | ||
| log.info("Running barn query on other connections (in get_solver_rewards") |
There was a problem hiding this comment.
What is the long term plan here? It seems that not setting the time out for barn is fine. But it also makes it a bit more difficult to understand what is happening here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the solver-rewards dry-run script returns fails in some environments due to the connection timing out. This PR adds some logging and explicitly sets the
tcp_keepalives_idlevalue to 900 seconds.