-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Restructure payouts #435
Draft
fhenneke
wants to merge
15
commits into
main
Choose a base branch
from
restructure_payouts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/fetch/payouts.py
# Conflicts: # src/fetch/payouts.py
harisang
added a commit
that referenced
this pull request
Dec 3, 2024
This PR changes how missing data for reward targets is identified. It fixes a bug where missing data causes the script to crash. The issue seems to come from a column without valid values being misidentified as float column and the missing value is encoded as `NaN`. This was not identified as missing data since it only checks for `None`. With this PR, the pandas function `isna` is used to identify missing data. A similar approach was used in #435. Since local tests are still running, I created this as draft PR. I will remove the draft status once the local run is successful. --------- Co-authored-by: Haris Angelidakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is an attempt at implementing #427. The PR does not change the values of final results (up to rounding of floats). It changes the structure of the code and intermediate representations.
As a first step, it separates the computation of different parts of the accounting into different functions.
Those functions are implemented in separate files
The results of these steps are converted into data frames for solver payments and for protocol and partner fee payments.
Additional changes could remove data frames from intermediate results. This would make it easier to have correct types and detect and handle missing data.
The code can be tested to produce the same transfer files as the old code.
Tests have not been adapted yet and are broken due to changes to intermediate results.