Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using string for solution_id #3154

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Dec 10, 2024

Description

Follow up for #3152, and a final step to switch to using INTEGER for solution id only.

Will be merged on Friday, once all solvers confirm they updated their drivers to include #3152.

OPENAPI is already up to date.

Fixes #3072

Changes

  • Stop accepting string type for solution id

How to test

e2e tests

@sunce86 sunce86 self-assigned this Dec 10, 2024
@sunce86 sunce86 requested a review from a team as a code owner December 10, 2024 10:53
Copy link
Contributor

@mstrug mstrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Stop using string for solution_id
4 participants