Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Order query fail when one request fail #18

Closed
anxolin opened this issue Apr 3, 2022 · 0 comments
Closed

Order query fail when one request fail #18

anxolin opened this issue Apr 3, 2022 · 0 comments
Labels
app:Explorer Explorer App Bug Something isn't working wontfix Stale issue

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 3, 2022

Description

Apparently, if one of the order queries fail with something other than 4xx error, the whole request fail even though there's data for the given order

Disclaimer: I have not reproduced it myself

How to Reproduce

This is tricky to reproduce as we have to force one of the backend enpoints to return a 500, but in summary the instructions are

  1. Go to any explorer endpoint (dev, staging, prod)
  2. Make one of the backend apis return 5xx for a given network
  3. With a valid orderId for one of the networks that's not returning 5xx, search for it in the search input
  4. The page will show you an "order not found" page

Expected behavior

Even though one of the networks is down, the call should not fail and the order in the appropriated network should load

Screenshots

image (12)

Additional context

Reported by Nick on #dex-web channel https://gnosisinc.slack.com/archives/CSGLUC1BN/p1634283179095400

Original issue gnosis/gp-ui#772 by @alfetopito

@anxolin anxolin added wontfix Stale issue Protofire app:Explorer Explorer App Bug Something isn't working labels Apr 3, 2022
@elena-zh elena-zh removed the Protofire label Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Bug Something isn't working wontfix Stale issue
Projects
None yet
Development

No branches or pull requests

2 participants