Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up redundant queries/code from PR #14 and also fix issue with non-Gnosis and non-CoW DAO pools #35

Open
harisang opened this issue Sep 17, 2024 · 0 comments
Open

Clean up redundant queries/code from PR #14 and also fix issue with non-Gnosis and non-CoW DAO pools #35

harisang opened this issue Sep 17, 2024 · 0 comments
Assignees
@bram-vdberg
Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details

Comments

@harisang
Copy link
Contributor

harisang commented Sep 17, 2024 •
edited
Loading

All queries related to PR #14 need to be revisited and redundant code should be removed.

Also, there is a bug, that currently doesn't affect things, but should be addressed asap. The query throughout assumes the existence of only 2 pools (CoW DAO and Gnosis), which is incorrect.
@harisang harisang changed the title Clean up redundant queries/code from PR #14 Clean up redundant queries/code from PR #14 and also fix issue with non-Gnosis and non-CoW DAO pools Sep 17, 2024
@fleupold fleupold added E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details and removed solver accounting labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bram-vdberg bram-vdberg

Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fleupold @harisang @bram-vdberg