Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent use of capitalization across queries #11

Open
bram-vdberg opened this issue Sep 5, 2024 · 1 comment
Open

Consistent use of capitalization across queries #11

bram-vdberg opened this issue Sep 5, 2024 · 1 comment
Assignees

Comments

@bram-vdberg
Copy link
Contributor

Background
In PR #10 there was a discussion about the inconsistency in SQL keyword capitalization across our queries. @fhenneke suggested enforcing this through linting checks. In order to enforce this we would also need to fix the capitalization in all queries to ensure they are consistent.

Proposed Solution

  1. Implement lowercase SQL syntax across all queries
  2. Add a linting check to enforce this in the CI:
[sqlfluff:rules:capitalisation.keywords]
capitalisation_policy = lower
@bram-vdberg bram-vdberg self-assigned this Sep 5, 2024
@fleupold
Copy link
Contributor

fleupold commented Sep 5, 2024

Sounds reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants