Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moo sound is played when convert vCOW to COW transaction is failed #370

Closed
elena-zh opened this issue Apr 5, 2022 · 1 comment
Closed

Moo sound is played when convert vCOW to COW transaction is failed #370

elena-zh opened this issue Apr 5, 2022 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

elena-zh commented Apr 5, 2022

Related to #365 , #349

  1. Run convert vCOW to COW transaction in Rinkeby
  2. Specify a gas limit at a low level (2 times lower)
    image.png
  3. Wait till the transaction fails

AR: MOO sound for the successful transaction is played
image.png

ER: no MOO sound for the failed transaction
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Apr 5, 2022
@elena-zh
Copy link
Author

elena-zh commented Apr 5, 2022

I can't retest it due to the issue #327 , but it would be nice to check that the sound is not played when a transaction is cancelled

@elena-zh elena-zh mentioned this issue Apr 5, 2022
Merged
@nenadV91 nenadV91 mentioned this issue Apr 6, 2022
Merged
@elena-zh elena-zh closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh