Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger integration #334

Closed
anxolin opened this issue Apr 2, 2022 · 1 comment
Closed

Ledger integration #334

anxolin opened this issue Apr 2, 2022 · 1 comment
Labels
app:CowSwap CowSwap app

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

We want to add Ledger as a wallet option to connect with.
https://developers.ledger.com/docs/transport/overview/

This is from 1Inch
Screenshot from 2022-03-31 11-46-14.png

This is from Paraswap
Screenshot from 2022-03-31 11-49-44.png

Original issue gnosis/cowswap#2619 by @nenadV91
@anxolin anxolin added the app:CowSwap CowSwap app label Apr 2, 2022
@alfetopito
Copy link
Collaborator

I looked at this awhile ago.
The initial integration is pretty straight forward, but that defaults to the first address only in your ledger, and doesn't allow for custom derivation paths.

To fully integrate we need to build/load some UI where users can pick which wallet they want to connect and so on.

@anxolin anxolin closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfetopito @anxolin