Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect amount of claimed tokens is displayed on waiting modal when re-run claim after failed Tx #308

Closed
anxolin opened this issue Apr 2, 2022 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

  1. Select select claim options, remember the claimed amount
  2. Send the TX to the connected wallet
  3. Change Gas limit in the connected wallet to be at less than a half of the required value
  4. Wait till the TX fails
  5. Go back, change claimed amount/options
  6. Send the TX to the connected wallet

AR: claimed amount for the 1st attempt is displayed in the 'Waiting' modal'
See the video: https://watch.screencastify.com/v/GFm16UWzH0k2Nltpzpl9

Note: the amount is changed after TX is signed

ER: no amount before TX signing should be displayed

Original issue gnosis/cowswap#2472 by @elena-zh

@anxolin anxolin added Claim Low Severity indicator for defects. It won't cause any major break-down of the system app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
@elena-zh
Copy link

elena-zh commented Apr 4, 2022

Closed as Claim page will be hidden based on the #349 task

@elena-zh elena-zh closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants