Composable cow #140

mfw78 · 2023-08-09T10:07:29Z

This PR:

Provides typedoc for all existing functions.
Adds support for ComposableCoW primitives including:
a. BaseConditionalOrder classes for order types to inherit from.
b. Multiplexer methods allowing for generating Merkle Trees of orders.

Outstanding items (to be handled in separate PR):

~~Refinement of ExtensibleFallbackHandler helper functions~~ Tracked in chore: rationalise ExtensibleFallbackHandler helper functions #141.

coveralls · 2023-08-09T10:09:03Z

coverage: 81.541% (+8.6%) from 72.93% when pulling 0623bc6 on composable-cow into 3abfdcf on main.

socket-security · 2023-08-09T10:10:39Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-plugin-unused-imports	3.0.0	None	`+1`	28.6 kB	sweepline
@openzeppelin/merkle-tree	1.0.5	None	`+6`	1.24 MB	frangio
typechain	8.3.1	filesystem	`+19`	1.48 MB	ethereum-ts-bot
@typechain/ethers-v5	11.1.1	filesystem	`+20`	1.57 MB	ethereum-ts-bot
@graphql-codegen/typescript-operations	3.0.0...3.0.4	None	`+27/-17`	4.11 MB	dotansimha

alfetopito

Wow, excellent documentation and testing work.

I have a few nitpicks, comments and questions

abi/ComposableCoW.json

src/common/consts.ts

src/composable/conditionalorder.spec.ts

src/composable/index.ts

src/composable/multiplexer.ts

src/composable/types/twap.ts

src/order-signing/orderSigningUtils.ts

src/composable/types/twap.ts

src/composable/conditionalorder.ts

…nused-vars Apparently the default checker is quite dumb and doesn't realize when a variable is exported/used in another file

alfetopito

Looking great!

2 comments which are not blockers

src/composable/multiplexer.ts

shoom3301

👍

mfw78 added 6 commits August 9, 2023 09:44

chore: repo config

16ce4fe

chore: sdk consts

d3d9edc

feat: eip-1271 signing utils

220a813

chore(es6): no async import

a1c4709

feat: composable cow abi

15a1fe7

feat: composable cow

3b6e91c

mfw78 requested review from anxolin and alfetopito and removed request for anxolin August 9, 2023 10:16

alfetopito reviewed Aug 9, 2023

View reviewed changes

shoom3301 reviewed Aug 10, 2023

View reviewed changes

src/composable/types/twap.ts Show resolved Hide resolved

shoom3301 reviewed Aug 10, 2023

View reviewed changes

src/composable/types/twap.ts Show resolved Hide resolved

shoom3301 reviewed Aug 10, 2023

View reviewed changes

src/composable/conditionalorder.ts Show resolved Hide resolved

shoom3301 reviewed Aug 10, 2023

View reviewed changes

src/composable/conditionalorder.ts Show resolved Hide resolved

mfw78 and others added 13 commits August 15, 2023 08:40

style: ABI formatting

ac5d157

fix: audited deployment addresses

30e393c

fix: remove commented code

5dddc3e

fix: eslint no-unused-vars

8a0e908

chore: update services repo tag to include openapi changes

f93d319

chore: use unused-imports/no-unused-vars for linting rather than no-u…

2797c4e

…nused-vars Apparently the default checker is quite dumb and doesn't realize when a variable is exported/used in another file

fix: dry code and remove non-null assertion

54add19

fix: tests twap address and multiplexer throw

3e5cb7c

fix: lazy constructor

9551e21

fix: extract constants

adafc93

fix: prettier

085ec7a

feat: single order calldata generation

5967be1

chore: revert lazy loading sign utils

9644893

mfw78 self-assigned this Aug 16, 2023

mfw78 requested review from alfetopito and shoom3301 August 16, 2023 09:34

alfetopito approved these changes Aug 16, 2023

View reviewed changes

src/composable/multiplexer.ts Outdated Show resolved Hide resolved

src/composable/multiplexer.ts Outdated Show resolved Hide resolved

shoom3301 approved these changes Aug 16, 2023

View reviewed changes

mfw78 added 2 commits August 16, 2023 12:45

fix: remove conflated callback mutation check

8e1899b

docs: sdk maintainer typedoc

0623bc6

mfw78 merged commit d682769 into main Aug 16, 2023

mfw78 deleted the composable-cow branch August 16, 2023 12:54

github-actions bot locked and limited conversation to collaborators Aug 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Composable cow #140

Composable cow #140

mfw78 commented Aug 9, 2023 •

edited

Loading

coveralls commented Aug 9, 2023 •

edited

Loading

socket-security bot commented Aug 9, 2023 •

edited

Loading

alfetopito left a comment

alfetopito left a comment

shoom3301 left a comment

Composable cow #140

Composable cow #140

Conversation

mfw78 commented Aug 9, 2023 • edited Loading

coveralls commented Aug 9, 2023 • edited Loading

socket-security bot commented Aug 9, 2023 • edited Loading

alfetopito left a comment

Choose a reason for hiding this comment

alfetopito left a comment

Choose a reason for hiding this comment

shoom3301 left a comment

Choose a reason for hiding this comment

mfw78 commented Aug 9, 2023 •

edited

Loading

coveralls commented Aug 9, 2023 •

edited

Loading

socket-security bot commented Aug 9, 2023 •

edited

Loading