Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test readability by making decimal place adjustments explicit #38

Open
lumoswiz opened this issue Jan 9, 2025 · 0 comments
Open

Comments

@lumoswiz
Copy link
Collaborator

lumoswiz commented Jan 9, 2025

Currently test cases accommodate decimal place adjustments implicitly in their assertions. Look to refactor this to make decimal adjustments more explicit.

Proposed improvement:

  • Express initial values explicitly with decimal places.
  • Make assertions that clearly show the decimal adjustment: assertEq(value * 10 ** (18 - D), otherValue);

This change will make the test logic more transparent and easier to maintain.

Reference: Discussion in PR #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant