Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot put cluster-global resources under app management #9

Open
8 tasks
tsutsu opened this issue Feb 4, 2021 · 0 comments
Open
8 tasks

Cannot put cluster-global resources under app management #9

tsutsu opened this issue Feb 4, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@tsutsu
Copy link
Member

tsutsu commented Feb 4, 2021

Mainly, CRDs. Maybe also ClusterRoleBindings, ServiceAccounts, etc. Probably because we can't add labels/annotations to them.

Fixing this requires a few things:

  1. split deploy-artifacts into "phases"
  • related issue in KustomizeR
  • generate multiple artifacts into deployment
    • detect phases that contain CRDs, and somehow mark their artifacts as "not to be annotated"
  1. somehow ensure Application Lifecycle Manager avoids annotating "not to be annotated" phases
  • will probably require replacing git-deployer with our own image
    • and then ensuring the do-deploy subcommand treats "not to be annotated" phases differently
    • or, doesn't annotate anything, but expects release subcommand to do those annotations instead!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant