Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boost module #351

Closed
wants to merge 13 commits into from
Closed

feat: add boost module #351

wants to merge 13 commits into from

Conversation

jeonghoyeo7
Copy link
Contributor

Description

This PR adds boost module.

closes: #349

Tasks

  • Scaffold boost module (define proto messages, define message types, keys, codec, params and etc)
  • Implement basic message server logic
  • Add CLI transaction commands
  • Add keeper test boilerplate (liquidity, farming, other modules)
  • Add necessary logics
  • Add gRPC queries
  • Add CLI query commands
  • Add spec docs
  • Add Import / Export genesis
  • Refactor overall codebase
  • Add test cases
  • Add CLI integration tests
  • Add simulation tests

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes


// NewHandler returns a new msg handler.
func NewHandler(k keeper.Keeper) sdk.Handler {
msgServer := keeper.NewMsgServerImpl(k)

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This definition of msgServer is never used.
msgServer := keeper.NewMsgServerImpl(k)

return func(ctx sdk.Context, msg sdk.Msg) (*sdk.Result, error) {
ctx = ctx.WithEventManager(sdk.NewEventManager())

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This definition of ctx is never used.
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 3, 2022
@github-actions github-actions bot closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add boost module
1 participant