Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HistoricalRewards gRPC query endpoint #334

Merged
merged 6 commits into from
Jul 12, 2022

Conversation

hallazzang
Copy link
Contributor

Description

This PR adds HistoricalRewards gRPC query endpoint and fixes some bugs regarding EnableAdvanceEpoch and EnableRatioPlan flags.

While the module has been upgraded to v2, REPO variable in Makefile hasn't been updated yet so that it wasn't setting EnableAdvanceEpoch and EnableRatioPlan flags properly.
Also there was another bug that importing x/liquidity/simulation/operations.go automatically sets EnableRatioPlan to true regardless of enableRatioPlan build flag.
These bugs will be fixed through this PR.

Tasks

  • Add QueryHistoricalRewards endpoint
  • Update API/CLI docs
  • Fix bugs with EnableAdvanceEpoch and EnableRatioPlan

also fix bug with `EnableAdvanceEpoch` and `EnableRatioPlan`
@hallazzang hallazzang self-assigned this Jul 12, 2022
@github-actions github-actions bot added build c-sync documentation Improvements or additions to documentation x/farming labels Jul 12, 2022
@hallazzang hallazzang marked this pull request as ready for review July 12, 2022 11:17
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the url in config-test.yml file as well?

@hallazzang
Copy link
Contributor Author

Can you fix the url in config-test.yml file as well?

Did that, I'm just wondering... should we update package path in *.proto files as well? Like in this file(proto/mint/v1beta1/mint.proto):

option go_package = "github.com/cosmosquad-labs/squad/x/mint/types";

@jaybxyz
Copy link
Contributor

jaybxyz commented Jul 12, 2022

I don't think we need to update package path in *.proto files. Doesn't it return an error if you change the path?

@hallazzang
Copy link
Contributor Author

I don't think we need to update package path in *.proto files. Doesn't it return an error if you change the path?

Yes, actually it's working without problem right now. Not updating the path in this PR, let's discuss about it later.

@hallazzang hallazzang merged commit a6b3c7b into main Jul 12, 2022
@hallazzang
Copy link
Contributor Author

@kogisin Please see #336 for further discussion.

@dongsam dongsam removed the c-sync label Jul 18, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
feat: add `HistoricalRewards` gRPC query endpoint #334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build documentation Improvements or additions to documentation x/farming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants