-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HistoricalRewards
gRPC query endpoint
#334
Conversation
also fix bug with `EnableAdvanceEpoch` and `EnableRatioPlan`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the url in config-test.yml file as well?
Did that, I'm just wondering... should we update package path in
|
I don't think we need to update package path in |
Yes, actually it's working without problem right now. Not updating the path in this PR, let's discuss about it later. |
@kogisin Please see #336 for further discussion. |
feat: add `HistoricalRewards` gRPC query endpoint #334
Description
This PR adds
HistoricalRewards
gRPC query endpoint and fixes some bugs regardingEnableAdvanceEpoch
andEnableRatioPlan
flags.While the module has been upgraded to
v2
,REPO
variable inMakefile
hasn't been updated yet so that it wasn't settingEnableAdvanceEpoch
andEnableRatioPlan
flags properly.Also there was another bug that importing
x/liquidity/simulation/operations.go
automatically setsEnableRatioPlan
totrue
regardless ofenableRatioPlan
build flag.These bugs will be fixed through this PR.
Tasks
QueryHistoricalRewards
endpointEnableAdvanceEpoch
andEnableRatioPlan