-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs to capture Permissionless ICS #2289
Conversation
@@ -171,7 +171,7 @@ message MsgCreateConsumer { | |||
} | |||
``` | |||
|
|||
Note that `metadata` is a required field, while the `initialization_parameterrs` and `power_shaping_parameters` are optional and can later be set using `MsgUpdateConsumer`. | |||
Note that `metadata` is a required field, while the `initialization_parameters` and `power_shaping_parameters` are optional and can later be set using `MsgUpdateConsumer`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took into account older comments that were added after the PR got merged.
@@ -28,9 +29,10 @@ A major feature of Interchain Security (also referred to as "Interchain Security | |||
This subset can be determined by the top N% validators by voting power, or by validators opting in to validate the consumer chain. | |||
PSS allows for more flexible security tradeoffs than Replicated Security. | |||
|
|||
## Mesh Security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not talk about Mesh security anywhere else so I think we can remove.
This is a security measure that makes it harder for a single large validator to take over a consumer chain: | ||
It mitigates the risk of an Opt In chain with only a few validators being dominated by a validator with a large amount of stake. | ||
For example, setting this fraction to 33% would mean that no single validator can have more than 33% of the total voting power on the consumer, and thus no single validator would be able to stop the consumer by going offline. | ||
The consumer chain can specify a _power cap_ which corresponds to the maximum power (percentage-wise) a validator can have on the consumer chain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People seemed to have difficulty understanding the validators power cap, so adding more examples here to make it more accessible. (cc @ve6a)
To avoid spam, the provider must whitelist denoms before accepting them as ICS rewards. | ||
|
||
## Reward distribution with power capping | ||
|
||
If a consumer chain has set a [validators-power cap](./power-shaping#capping-the-validator-powers), then the total received |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ve6a, I'm adding more information here on the reward distribution to hopefully make it more understandable to users. Let me know if there are any concerns.
456d6a3
to
f6a9c10
Compare
To avoid spam, the provider must whitelist denoms before accepting them as ICS rewards. | ||
|
||
## Reward distribution with power capping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ve6a
init commit (cherry picked from commit c630c28)
docs: update docs to capture Permissionless ICS (#2289) init commit (cherry picked from commit c630c28) Co-authored-by: insumity <[email protected]>
Description
This is a first attempt at updating the docs to capture the latest Permissionless ICS changes.
This PR does not yet change the docs under:
docs/docs/validators/changeover-procedure.md
docs/docs/validators/joining-neutron.md
docs/docs/validators/joining-stride.md
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR titlemake build-docs
)