Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add check for the height of evidence (backport #2007) #2010

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix!: add check for the height of evidence (backport #2007) #2010

merged 1 commit into from
Jul 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 3, 2024

Please go to the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where the minimum height check for evidence in the consumer double-vote handler was missing, improving validation and error handling for double voting evidence.

  • Tests

    • Enhanced integration tests to better handle and validate scenarios involving double voting and misbehavior checks.

  • New Features

    • Added functionality to set and delete the minimum height for equivocation evidence related to a consumer chain.
This is an automatic backport of pull request #2007 done by [Mergify](https://mergify.com).

@sainoe @mergify
fix!: add check for the height of evidence (#2007)
2dbb073 
* init commit

* added check, setting, and deleting of the equivocation min height

* update changelog entry

* remove unwwanted changelog entry

---------

Co-authored-by: insumity <[email protected]>
(cherry picked from commit de9db96)
@mergify mergify bot requested a review from a team as a code owner July 3, 2024 15:57
@mergify mergify bot assigned sainoe Jul 3, 2024
@github-actions github-actions bot added C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Jul 3, 2024
@sainoe sainoe merged commit 19f7fa2 into release/v4.3.x Jul 4, 2024
16 of 17 checks passed
@sainoe sainoe deleted the mergify/bp/release/v4.3.x/pr-2007 branch July 4, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

Assignees

@sainoe sainoe

Labels
C:Testing Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpoke @sainoe