Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Require one active validator to opt-in for a consumer chain to launch #2397

Closed
1 task
Tracked by #2382
mpoke opened this issue Nov 12, 2024 · 1 comment · Fixed by #2399
Closed
1 task
Tracked by #2382

[Feature]: Require one active validator to opt-in for a consumer chain to launch #2397

mpoke opened this issue Nov 12, 2024 · 1 comment · Fixed by #2399
Assignees
Labels
type: feature-request New feature or request improvement

Comments

@mpoke
Copy link
Contributor

mpoke commented Nov 12, 2024

Summary

Currently, the requirement for a consumer chain to launch is to have at least one eligible validator opted in. This includes inactive validators. Given the relative low cost of creating an inactive validator (see https://www.mintscan.io/cosmos/validators), an attacker could launch a large number of consumer chains. Currently, ICS is a "push" protocol, i.e., the provider sends validator updates to all the launched consumer chains. Since this happens in the EndBlock of the provider module, there is a risk of DOS attacks.

Problem Definition

No response

Proposed Feature

A long-term solution is to make ICS a "pull" protocol. Basically, consumer chains will need to query the provider validator updates using interchain queries. This will take time to implement.

In the meantime, a short-term solution is to require at least one active validator to opt-in on a consumer chain for that chain to launch.

Work Breakdown

Must have

Preview Give feedback
@mpoke mpoke added the type: feature-request New feature or request improvement label Nov 12, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Nov 12, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Nov 12, 2024
@insumity insumity self-assigned this Nov 12, 2024
@mpoke
Copy link
Contributor Author

mpoke commented Nov 18, 2024

@insumity could you please also limit the number of consumer chains a validator could opt in? It should be a provider param and the default to something like 1000.

@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Dec 3, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature-request New feature or request improvement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants