Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Set Security: Drop chain proposals with empty validator set at spawn time #1886

Closed
insumity opened this issue May 16, 2024 · 0 comments · Fixed by #1888
Closed

Partial Set Security: Drop chain proposals with empty validator set at spawn time #1886

insumity opened this issue May 16, 2024 · 0 comments · Fixed by #1888
Assignees
Labels
scope: provider Issues related to the provider chain source: devnet To indicate an issue surfaced in a devnet. type: bug Issues that need priority attention -- something isn't working

Comments

@insumity
Copy link
Contributor

Problem

Consider a consumer addition proposal for an Opt In chain chainID that is voted on but no validator opts in during the voting period. The generated consumer genesis file would have any empty validator set. So, the chain won't be able to start. Nevertheless we still store data about chainID such as denylists, etc. This means that no chain with chainID will be able to be voted upon unless chainID gets first removed.

Closing criteria

If a chain ends up with a genesis that has an empty validator set, we should just drop the proposal and not store anything in regards to this chain.

Thanks to @dasanchez for finding this out!

@insumity insumity added type: bug Issues that need priority attention -- something isn't working scope: provider Issues related to the provider chain source: devnet To indicate an issue surfaced in a devnet. labels May 16, 2024
@insumity insumity self-assigned this May 16, 2024
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub May 16, 2024
@insumity insumity moved this from 🩹 F1: Triage to 🏗 F3: InProgress in Cosmos Hub May 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗 F3: InProgress to 👍 F4: Assessment in Cosmos Hub May 17, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: provider Issues related to the provider chain source: devnet To indicate an issue surfaced in a devnet. type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
1 participant