Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-couple actions from TestConfig #1325

Closed
Tracked by #2283
p-offtermatt opened this issue Sep 25, 2023 · 1 comment
Closed
Tracked by #2283

De-couple actions from TestConfig #1325

p-offtermatt opened this issue Sep 25, 2023 · 1 comment
Labels
good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented Sep 25, 2023 •
edited
Loading

Right now, the actions are methods of the test config.
This seems strange, and we might want to refactor this in the future, for example actions could take configs as an input.
This is not high-priority, but if we refactor the e2e framework, this might be something to keep in mind.

See #1318
@p-offtermatt p-offtermatt added good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification. S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability labels Sep 25, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Sep 25, 2023
@p-offtermatt p-offtermatt mentioned this issue Sep 25, 2023
Merged
8 tasks
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Nov 16, 2023
@mpoke mpoke removed the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 17, 2024
@mpoke mpoke mentioned this issue Sep 18, 2024
Open
@mpoke
Copy link
Contributor

mpoke commented Dec 9, 2024

Closing as the objective should be to deprecate existing e2e tests in favor of the interchain tests.

@mpoke mpoke closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Dec 9, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpoke @p-offtermatt