Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storage of PendingPackets on consumer #1033

Closed
Tracked by #713
shaspitz opened this issue Jun 16, 2023 · 2 comments · Fixed by #1037
Closed
Tracked by #713

Improve storage of PendingPackets on consumer #1033

shaspitz opened this issue Jun 16, 2023 · 2 comments · Fixed by #1037
Assignees

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Jun 16, 2023

Problem

The consumer ccv module currently queues "pending packets" to be sent on each endblocker in SendPackets. These packets are queued using a protobuf list in ConsumerPacketData. For a single append operation, the entire list is deserialized, then a packet is appended to that list, and the list is serialized again, See AppendPendingPacket. That is, a single append operation has O(N) complexity, where N is the size of the list. This isn't a problem when the list is small. But with #713 being implemented, this list can potentially grow to the order of thousands of entries, in the scenario that a slash packet is bouncing.

Proposed solution

We can improve the append time for this queue by converting it from a protobuf-esq list, to a queue implemented with sdk-esq code.

My rough idea: The key schema for storing slash and VSC matured packets will look like [prefix]-[blockheight] and the value for each key will contain a protobuf list with any packets queued for that blockheight. Since we're keying by blockheight, an sdk iterator will iterate over the keys in FIFO order. That's it. We'll have to append to a protobuf list, but only for multiple packets that're queued during the same blockheight. Otherwise if most packets are queued from different block heights (which is surely the case for VSCMatured packets), appending to the queue is near constant time.

Note this should be solved in it's own PR separate from other throttle related changes

@shaspitz shaspitz changed the title Storage of PendingPackets on consumer Improve storage of PendingPackets on consumer Jun 16, 2023
@shaspitz
Copy link
Contributor Author

cc @jtremback since we chatted about this

@shaspitz
Copy link
Contributor Author

Actually theres an even simpler way to approach this problem.

Store a head/tail integer for the pending packets queue. Whenever you append to the queue, simply store the new entry with key looking like: [prefix-tail+1]. Then Increment tail.

For access, leverage sdk's iterator, keys are already ordered by ascending bytes.

Maybe there's already some queue boilerplate in sdk? I'll take a look on Monday

@mpoke mpoke added this to Cosmos Hub Jun 20, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jun 20, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Jun 20, 2023
@shaspitz shaspitz moved this from 📥 Todo to 🏗 In progress in Cosmos Hub Jun 21, 2023
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant