From 28d4cc2550035629f30d7c9bf27ff46cb6c288a4 Mon Sep 17 00:00:00 2001 From: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com> Date: Wed, 6 Dec 2023 13:40:07 +0100 Subject: [PATCH 1/3] Update tests/e2e/README.md Co-authored-by: Marius Poke --- tests/e2e/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/e2e/README.md b/tests/e2e/README.md index edf7c37ee1..f68e25ed66 100644 --- a/tests/e2e/README.md +++ b/tests/e2e/README.md @@ -115,8 +115,7 @@ there is likely no existing action to submit these transactions to the chain. You can see the basic template for how to do this by looking at the actions in (actions.go)[actions.go]. -The basic principle is to use exec.Command to execute a docker exec to execute a -command inside the docker container. +The basic principle is to use `exec.Command` to execute a command inside the docker container. The pattern for this looks something like this: ``` cmd := exec.Command("docker", "exec", From 8924fe244fd27e45ce4e83133a5de6841038749a Mon Sep 17 00:00:00 2001 From: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com> Date: Wed, 6 Dec 2023 13:40:34 +0100 Subject: [PATCH 2/3] Update tests/e2e/README.md Co-authored-by: Marius Poke --- tests/e2e/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/README.md b/tests/e2e/README.md index f68e25ed66..5b9a040bb6 100644 --- a/tests/e2e/README.md +++ b/tests/e2e/README.md @@ -132,7 +132,7 @@ if err != nil { // potentially check something in the output, or log something, ... ``` -Remember that actions don't need to check that the state was modified correctly, +**Note:** Actions don't need to check that the state was modified correctly, since we have the state checks for this. Still, it's generally a good idea to do a basic check for errors, since in case the action encounters an error, From 2dae5b962900ed8edd068dcffb15afe8d2b4acb1 Mon Sep 17 00:00:00 2001 From: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com> Date: Wed, 6 Dec 2023 13:46:19 +0100 Subject: [PATCH 3/3] Update tests/e2e/README.md Co-authored-by: Marius Poke --- tests/e2e/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/README.md b/tests/e2e/README.md index 5b9a040bb6..ae04d03e0f 100644 --- a/tests/e2e/README.md +++ b/tests/e2e/README.md @@ -198,7 +198,7 @@ When something in the tests goes wrong, a nice thing about the tests is that the docker container doesn't get killed. You can sh into the docker container via e.g. `docker exec -it "testinstance" sh` and manually look around, Useful pointers are: -* Look at logs in the node homes: `/$CHAIN_ID/validator$VAL_ID` +* Look at logs in the nodes' home folder, i.e., `/$CHAIN_ID/validator$VAL_ID` * Query/Run txs on the running apps (find out the relevant addresses and node homes to use e.g. by running `htop "binaryname"`) It is also possible to locally change a step so it will *always* fail (e.g. by checking for nonsense validator balances)