From c881a1aad37f2f8041c913468602edaf69fef9bf Mon Sep 17 00:00:00 2001
From: Simon Noetzlin <simon.ntz@gmail.com>
Date: Mon, 11 Sep 2023 18:21:15 +0200
Subject: [PATCH] test: add E2E tests for double voting evidence handling
 (#1256)

* fix double voting cli

* add double-signing e2e test

* refortmat e2e double voting test

* godoc, revert unwanted changes

* nit

* verify dv evidence using malicious validator pubkey in infraction block header

* save changes

* fix hermes config

* fist successful run

* nit

* nits

* nits

* doc and nits

* lint

* refactor

* typo

* change hermes docker image

* nits

* Update tests/e2e/steps.go

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>

* address PR comments

* nits

---------

Co-authored-by: Philip Offtermatt <57488781+p-offtermatt@users.noreply.github.com>
---
 tests/e2e/main.go              |  2 +
 tests/e2e/steps.go             | 10 ++++-
 tests/e2e/steps_double_sign.go | 76 ++++++++++++++++++++++++++++++++++
 3 files changed, 87 insertions(+), 1 deletion(-)

diff --git a/tests/e2e/main.go b/tests/e2e/main.go
index 84a06eeab9..ac9becdd5e 100644
--- a/tests/e2e/main.go
+++ b/tests/e2e/main.go
@@ -63,7 +63,9 @@ func main() {
 		{DemocracyTestRun(false), rewardDenomConsumerSteps},
 		{SlashThrottleTestRun(), slashThrottleSteps},
 		{ConsumerMisbehaviourTestRun(), consumerMisbehaviourSteps},
+		{DefaultTestRun(), consumerDoubleSignSteps},
 	}
+
 	if includeMultiConsumer != nil && *includeMultiConsumer {
 		testRuns = append(testRuns, testRunWithSteps{MultiConsumerTestRun(), multipleConsumers})
 	}
diff --git a/tests/e2e/steps.go b/tests/e2e/steps.go
index 78a56654e6..fb506eff5f 100644
--- a/tests/e2e/steps.go
+++ b/tests/e2e/steps.go
@@ -91,6 +91,14 @@ var changeoverSteps = concatSteps(
 var consumerMisbehaviourSteps = concatSteps(
 	// start provider and consumer chain
 	stepsStartChainsWithSoftOptOut("consu"),
-	// make consumer validator to misbehave and get jail
+	// make a consumer validator to misbehave and get jailed
 	stepsCauseConsumerMisbehaviour("consu"),
 )
+
+var consumerDoubleSignSteps = concatSteps(
+	// start provider and consumer chain
+	stepsStartChains([]string{"consu"}, false),
+
+	// make a consumer validator double sign and get jailed
+	stepsCauseDoubleSignOnConsumer("consu", "provi"),
+)
diff --git a/tests/e2e/steps_double_sign.go b/tests/e2e/steps_double_sign.go
index c007fa5c1c..dcce236b46 100644
--- a/tests/e2e/steps_double_sign.go
+++ b/tests/e2e/steps_double_sign.go
@@ -128,3 +128,79 @@ func stepsDoubleSignOnProviderAndConsumer(consumerName string) []Step {
 		},
 	}
 }
+
+// Steps that make bob double sign on the consumer
+func stepsCauseDoubleSignOnConsumer(consumerName, providerName string) []Step {
+	return []Step{
+		{
+			action: doublesignSlashAction{
+				chain:     chainID(consumerName),
+				validator: validatorID("bob"),
+			},
+			state: State{
+				chainID(providerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   500,
+						validatorID("carol"): 500,
+					},
+				},
+				chainID(consumerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   500,
+						validatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		// detect the double voting infraction
+		// and jail bob on the provider
+		{
+			action: detectConsumerEvidenceAction{
+				chain: chainID(consumerName),
+			},
+			state: State{
+				chainID(providerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   0,
+						validatorID("carol"): 500,
+					},
+				},
+				chainID(consumerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   500,
+						validatorID("carol"): 500,
+					},
+				},
+			},
+		},
+		// consumer learns about the jailing
+		{
+			action: relayPacketsAction{
+				chainA:  chainID(providerName),
+				chainB:  chainID(consumerName),
+				port:    "provider",
+				channel: 0,
+			},
+			state: State{
+				chainID(providerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   0,
+						validatorID("carol"): 500,
+					},
+				},
+				chainID(consumerName): ChainState{
+					ValPowers: &map[validatorID]uint{
+						validatorID("alice"): 500,
+						validatorID("bob"):   0,
+						validatorID("carol"): 500,
+					},
+				},
+			},
+		},
+	}
+}