Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix packet and acknowledgement commitments with a protocol version byte #1161

Open
AdityaSripal opened this issue Nov 6, 2024 · 0 comments
Labels
feat/eureka v2 TAO specification

Comments

@AdityaSripal
Copy link
Member

If we prefix packet and acknowledgement commitments with a version byte, then we can easily differentiate between different protocol versions.

By looking at the first byte, we know which version the packet is committing to. For IBC v2, we can prefix the packet and acknowledgement commitment by the byte 0x02.

Thus, if we ever want to upgrade the protocol and change the provable commitments; we can simply change the first version byte. This will then be rejected by all previous versions; while being accepted and properly committed to by platforms that support the new versions.

I think this is a proposal we should accept and I will put up a PR implementing this.

It's an open question if we need to do the same for receipts.

@AdityaSripal AdityaSripal changed the title Prefix packet and acknowledgement commitments with a version byte Prefix packet and acknowledgement commitments with a protocol version byte Nov 6, 2024
@womensrights womensrights added the feat/eureka v2 TAO specification label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/eureka v2 TAO specification
Projects
Status: Backlog
Development

No branches or pull requests

2 participants