Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize redundant storage calls during send(_nft)_transfer #1301

Open
Farhad-Shabani opened this issue Aug 5, 2024 · 0 comments
Open

Optimize redundant storage calls during send(_nft)_transfer #1301

Farhad-Shabani opened this issue Aug 5, 2024 · 0 comments
Labels
O: optimization Objective: aims to optimize performance, allocations and computations

Comments

@Farhad-Shabani
Copy link
Member

Description

While reviewing the send_transfer entrypoint, I've noticed we're making the same storage calls multiple times across different stages, which is inefficient. Specifically, this happens in the following parts of the process for the channel end:

And for the next sequence send:

Given that this is a hot path for every ICS-20 and ICS-721 packets, it's crucial to devise a more efficient implementation to optimize these redundant calls. This is the case for the send_nft_transfer() as well.

@Farhad-Shabani Farhad-Shabani added the O: optimization Objective: aims to optimize performance, allocations and computations label Aug 5, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: optimization Objective: aims to optimize performance, allocations and computations
Projects
Status: 📥 To Do
Development

No branches or pull requests

1 participant