Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of domain types' fields to public #1228

Open
1 task
seanchen1991 opened this issue May 15, 2024 · 0 comments
Open
1 task

Change visibility of domain types' fields to public #1228

seanchen1991 opened this issue May 15, 2024 · 0 comments
Assignees
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability

Comments

@seanchen1991
Copy link
Contributor

Follow up issue to this discussion proposed by @soareschen.

Background

In summary, there is very little benefit to protecting domain type fields, especially since they all have auto-derive instances of serde::{Serialize, Deserialize}. It would only make sense to keep the fields private if we were hand-deriving the serialization logic, but with auto-derived instances, this leaves a backdoor open for vulnerabilities as far as validation of these domain type fields is concerned. So perhaps it makes sense to make all domain type fields public.

Proposal

  • Make all fields of all domain types in ibc-rs public
@romac romac changed the title Make Msg* structs pub Chamge visibilty of domain types' fields to public May 15, 2024
@romac romac changed the title Chamge visibilty of domain types' fields to public Change visibilty of domain types' fields to public May 15, 2024
@seanchen1991 seanchen1991 changed the title Change visibilty of domain types' fields to public Change visibility of domain types' fields to public May 16, 2024
@seanchen1991 seanchen1991 moved this to 📥 To Do in ibc-rs Jun 3, 2024
@seanchen1991 seanchen1991 self-assigned this Jun 19, 2024
@rnbguy rnbguy added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
Status: 📥 To Do
Development

No branches or pull requests

2 participants