You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In summary, there is very little benefit to protecting domain type fields, especially since they all have auto-derive instances of serde::{Serialize, Deserialize}. It would only make sense to keep the fields private if we were hand-deriving the serialization logic, but with auto-derived instances, this leaves a backdoor open for vulnerabilities as far as validation of these domain type fields is concerned. So perhaps it makes sense to make all domain type fields public.
Proposal
Make all fields of all domain types in ibc-rs public
The text was updated successfully, but these errors were encountered:
romac
changed the title
Make Msg* structs pub
Chamge visibilty of domain types' fields to public
May 15, 2024
romac
changed the title
Chamge visibilty of domain types' fields to public
Change visibilty of domain types' fields to public
May 15, 2024
seanchen1991
changed the title
Change visibilty of domain types' fields to public
Change visibility of domain types' fields to public
May 16, 2024
Follow up issue to this discussion proposed by @soareschen.
Background
In summary, there is very little benefit to protecting domain type fields, especially since they all have auto-derive instances of
serde::{Serialize, Deserialize}
. It would only make sense to keep the fields private if we were hand-deriving the serialization logic, but with auto-derived instances, this leaves a backdoor open for vulnerabilities as far as validation of these domain type fields is concerned. So perhaps it makes sense to make all domain type fields public.Proposal
ibc-rs
publicThe text was updated successfully, but these errors were encountered: