Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammend 08-wasm simapp with testing/simapp changes #4744

Closed
3 tasks
DimitrisJim opened this issue Sep 21, 2023 · 3 comments
Closed
3 tasks

Ammend 08-wasm simapp with testing/simapp changes #4744

DimitrisJim opened this issue Sep 21, 2023 · 3 comments
Assignees
Labels

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Sep 21, 2023

Requires sdk50 and a sync of feat/wasm-clients to main. Then the following need to be done:


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim changed the title Ammend wasm simapp with testing/simapp changes Ammend 08-wasm simapp with testing/simapp changes Sep 21, 2023
@chatton
Copy link
Contributor

chatton commented Sep 21, 2023

We can probably remove the gov router in the callbacks and wasm simapps, but I don't think there's any rush to do it all, I think we can still just do it all in the one PR when we merge it in the end.

@DimitrisJim
Copy link
Contributor Author

sounds like a plan, can amend parent issue

@DimitrisJim DimitrisJim self-assigned this Sep 27, 2023
@DimitrisJim
Copy link
Contributor Author

Done in #4805, router removal is tracked in #4671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants