From 690e885f09c53db76ca4a303bacbc490189fce23 Mon Sep 17 00:00:00 2001
From: Damian Nolan <damiannolan@gmail.com>
Date: Mon, 27 Nov 2023 18:05:56 +0100
Subject: [PATCH] test: adding test for crossing hello trys with historical
 proofs (#5143)

* test: adding test for crossing hello trys with historical proofs

* chore: make format

* chore: address TODO in test case with switch of proof query endpoint
---
 .../core/04-channel/keeper/upgrade_test.go    | 75 +++++++++++++++++++
 1 file changed, 75 insertions(+)

diff --git a/modules/core/04-channel/keeper/upgrade_test.go b/modules/core/04-channel/keeper/upgrade_test.go
index 74d86056208..fe31eff07b5 100644
--- a/modules/core/04-channel/keeper/upgrade_test.go
+++ b/modules/core/04-channel/keeper/upgrade_test.go
@@ -2186,3 +2186,78 @@ func (suite *KeeperTestSuite) TestSyncUpgradeSequence() {
 		})
 	}
 }
+
+func (suite *KeeperTestSuite) TestChanUpgradeCrossingHelloWithHistoricalProofs() {
+	var path *ibctesting.Path
+
+	testCases := []struct {
+		name     string
+		malleate func()
+		expError error
+	}{
+		{
+			"success",
+			func() {},
+			nil,
+		},
+		{
+			"counterparty (chain B) has already progressed to ACK step",
+			func() {
+				err := path.EndpointB.ChanUpgradeAck()
+				suite.Require().NoError(err)
+			},
+			types.ErrInvalidChannelState,
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		suite.Run(tc.name, func() {
+			suite.SetupTest()
+
+			path = ibctesting.NewPath(suite.chainA, suite.chainB)
+			suite.coordinator.Setup(path)
+
+			path.EndpointA.ChannelConfig.ProposedUpgrade.Fields.Version = mock.UpgradeVersion
+			path.EndpointB.ChannelConfig.ProposedUpgrade.Fields.Version = mock.UpgradeVersion
+
+			err := path.EndpointA.ChanUpgradeInit()
+			suite.Require().NoError(err)
+
+			err = path.EndpointB.ChanUpgradeInit()
+			suite.Require().NoError(err)
+
+			suite.coordinator.CommitBlock(suite.chainA, suite.chainB)
+
+			err = path.EndpointB.UpdateClient()
+			suite.Require().NoError(err)
+
+			historicalChannelProof, historicalUpgradeProof, proofHeight := path.EndpointA.QueryChannelUpgradeProof()
+
+			err = path.EndpointA.ChanUpgradeTry()
+			suite.Require().NoError(err)
+
+			tc.malleate()
+
+			upgrade, err := suite.chainB.GetSimApp().GetIBCKeeper().ChannelKeeper.ChanUpgradeTry(
+				suite.chainB.GetContext(),
+				path.EndpointB.ChannelConfig.PortID,
+				path.EndpointB.ChannelID,
+				path.EndpointB.GetChannelUpgrade().Fields.ConnectionHops,
+				path.EndpointA.GetChannelUpgrade().Fields,
+				1,
+				historicalChannelProof,
+				historicalUpgradeProof,
+				proofHeight,
+			)
+
+			expPass := tc.expError == nil
+			if expPass {
+				suite.Require().NoError(err)
+				suite.Require().NotEmpty(upgrade)
+			} else {
+				suite.Require().ErrorIs(err, tc.expError)
+			}
+		})
+	}
+}