From 86382aa74660bba2522f19c323dc4cdd98d7bf4b Mon Sep 17 00:00:00 2001 From: Marius Poke Date: Tue, 13 Feb 2024 10:01:47 +0100 Subject: [PATCH] feat!: bump SDK to v0.47.8-ics-lsm (#2919) * bump SDK to v0.47.8-ics-lsm * update changelog entries * add api breaking changelog entry for 2912 * chore: bump ics; update changelogs --------- Co-authored-by: MSalopek --- .changelog/unreleased/api-breaking/2885-bump-ics.md | 2 +- .changelog/unreleased/api-breaking/2912-vote-spam.md | 2 ++ .changelog/unreleased/api-breaking/2919-bump-sdk.md | 8 ++++++++ .changelog/unreleased/bug-fixes/2919-bump-sdk.md | 12 ++++++++++++ .changelog/unreleased/dependencies/2885-bump-ics.md | 4 ++-- .changelog/unreleased/dependencies/2919-bump-sdk.md | 4 ++++ .../unreleased/state-breaking/2885-bump-ics.md | 4 ++-- .../unreleased/state-breaking/2919-bump-sdk.md | 5 +++++ go.mod | 4 ++-- go.sum | 8 ++++---- 10 files changed, 42 insertions(+), 11 deletions(-) create mode 100644 .changelog/unreleased/api-breaking/2912-vote-spam.md create mode 100644 .changelog/unreleased/api-breaking/2919-bump-sdk.md create mode 100644 .changelog/unreleased/bug-fixes/2919-bump-sdk.md create mode 100644 .changelog/unreleased/dependencies/2919-bump-sdk.md create mode 100644 .changelog/unreleased/state-breaking/2919-bump-sdk.md diff --git a/.changelog/unreleased/api-breaking/2885-bump-ics.md b/.changelog/unreleased/api-breaking/2885-bump-ics.md index ea0a340d570..e136c59a28e 100644 --- a/.changelog/unreleased/api-breaking/2885-bump-ics.md +++ b/.changelog/unreleased/api-breaking/2885-bump-ics.md @@ -1,4 +1,4 @@ - The consumer CCV genesis state obtained from the provider chain needs to be transformed to be compatible with older versions of consumer chains (see [ICS docs](https://cosmos.github.io/interchain-security/consumer-development/consumer-genesis-transformation)). - ([\#2885](https://github.com/cosmos/gaia/pull/2885)) \ No newline at end of file + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) \ No newline at end of file diff --git a/.changelog/unreleased/api-breaking/2912-vote-spam.md b/.changelog/unreleased/api-breaking/2912-vote-spam.md new file mode 100644 index 00000000000..7de12dbd7c4 --- /dev/null +++ b/.changelog/unreleased/api-breaking/2912-vote-spam.md @@ -0,0 +1,2 @@ +- Reject `MsgVote` messages from accounts with less than 1 atom staked. + ([\#2912](https://github.com/cosmos/gaia/pull/2912)) \ No newline at end of file diff --git a/.changelog/unreleased/api-breaking/2919-bump-sdk.md b/.changelog/unreleased/api-breaking/2919-bump-sdk.md new file mode 100644 index 00000000000..500ef5a10f2 --- /dev/null +++ b/.changelog/unreleased/api-breaking/2919-bump-sdk.md @@ -0,0 +1,8 @@ +- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to + [v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm). + As compared to [v0.47.8](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8), + this special branch of cosmos-sdk has the following API-breaking changes: + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) + - Limit the accepted deposit coins for a proposal to the minimum proposal deposit denoms (e.g., `uatom` for Cosmos Hub). ([sdk-#19302](https://github.com/cosmos/cosmos-sdk/pull/19302)) + - Add denom check to reject denoms outside of those listed in `MinDeposit`. A new `MinDepositRatio` param is added (with a default value of `0.01`) and now deposits are required to be at least `MinDepositRatio*MinDeposit` to be accepted. ([sdk-#2919](https://github.com/cosmos/cosmos-sdk/pull/19312)) + - Disable the `DenomOwners` query. ([sdk-#19266](https://github.com/cosmos/cosmos-sdk/pull/19266)) \ No newline at end of file diff --git a/.changelog/unreleased/bug-fixes/2919-bump-sdk.md b/.changelog/unreleased/bug-fixes/2919-bump-sdk.md new file mode 100644 index 00000000000..4f8ffd771cd --- /dev/null +++ b/.changelog/unreleased/bug-fixes/2919-bump-sdk.md @@ -0,0 +1,12 @@ +- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to + [v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm). + This special branch of cosmos-sdk backports a series of fixes for issues found + during the [Oak Security audit of SDK 0.47](https://github.com/oak-security/audit-reports/blob/master/Cosmos%20SDK/2024-01-23%20Audit%20Report%20-%20Cosmos%20SDK%20v1.0.pdf). + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) + - Backport [sdk-#18146](https://github.com/cosmos/cosmos-sdk/pull/18146): Add denom check to reject denoms outside of those listed in `MinDeposit`. A new `MinDepositRatio` param is added (with a default value of `0.01`) and now deposits are required to be at least `MinDepositRatio*MinDeposit` to be accepted. ([sdk-#2919](https://github.com/cosmos/cosmos-sdk/pull/19312)) + - Partially backport [sdk-#18047](https://github.com/cosmos/cosmos-sdk/pull/18047): Add a limit of 200 grants pruned per `EndBlock` in the feegrant module. ([sdk-#19314](https://github.com/cosmos/cosmos-sdk/pull/19314)) + - Partially backport [skd-#18737](https://github.com/cosmos/cosmos-sdk/pull/18737): Add a limit of 200 grants pruned per `BeginBlock` in the authz module. ([sdk-#19315](https://github.com/cosmos/cosmos-sdk/pull/19315)) + - Backport [sdk-#18173](https://github.com/cosmos/cosmos-sdk/pull/18173): Gov Hooks now returns error and are "blocking" if they fail. Expect for `AfterProposalFailedMinDeposit` and `AfterProposalVotingPeriodEnded` that will log the error and continue. ([sdk-#19305](https://github.com/cosmos/cosmos-sdk/pull/19305)) + - Backport [sdk-#18189](https://github.com/cosmos/cosmos-sdk/pull/18189): Limit the accepted deposit coins for a proposal to the minimum proposal deposit denoms. ([sdk-#19302](https://github.com/cosmos/cosmos-sdk/pull/19302)) + - Backport [sdk-#18214](https://github.com/cosmos/cosmos-sdk/pull/18214) and [sdk-#17352](https://github.com/cosmos/cosmos-sdk/pull/17352): Ensure that modifying the argument to `NewUIntFromBigInt` and `NewIntFromBigInt` doesn't mutate the returned value. ([sdk-#19293](https://github.com/cosmos/cosmos-sdk/pull/19293)) + \ No newline at end of file diff --git a/.changelog/unreleased/dependencies/2885-bump-ics.md b/.changelog/unreleased/dependencies/2885-bump-ics.md index 68cdb29e064..3b540dd83be 100644 --- a/.changelog/unreleased/dependencies/2885-bump-ics.md +++ b/.changelog/unreleased/dependencies/2885-bump-ics.md @@ -1,3 +1,3 @@ - Bump [ICS](https://github.com/cosmos/interchain-security) to - [v3.3.0](https://github.com/cosmos/interchain-security/releases/tag/v3.3.0) - ([\#2885](https://github.com/cosmos/gaia/pull/2885)) \ No newline at end of file + [v3.3.1-lsm](https://github.com/cosmos/interchain-security/releases/tag/v3.3.1-lsm) + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) \ No newline at end of file diff --git a/.changelog/unreleased/dependencies/2919-bump-sdk.md b/.changelog/unreleased/dependencies/2919-bump-sdk.md new file mode 100644 index 00000000000..cb4ae2c3ec1 --- /dev/null +++ b/.changelog/unreleased/dependencies/2919-bump-sdk.md @@ -0,0 +1,4 @@ +- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to + [v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm). + This is a special cosmos-sdk branch with support for both ICS and LSM. + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) \ No newline at end of file diff --git a/.changelog/unreleased/state-breaking/2885-bump-ics.md b/.changelog/unreleased/state-breaking/2885-bump-ics.md index 68cdb29e064..3b540dd83be 100644 --- a/.changelog/unreleased/state-breaking/2885-bump-ics.md +++ b/.changelog/unreleased/state-breaking/2885-bump-ics.md @@ -1,3 +1,3 @@ - Bump [ICS](https://github.com/cosmos/interchain-security) to - [v3.3.0](https://github.com/cosmos/interchain-security/releases/tag/v3.3.0) - ([\#2885](https://github.com/cosmos/gaia/pull/2885)) \ No newline at end of file + [v3.3.1-lsm](https://github.com/cosmos/interchain-security/releases/tag/v3.3.1-lsm) + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) \ No newline at end of file diff --git a/.changelog/unreleased/state-breaking/2919-bump-sdk.md b/.changelog/unreleased/state-breaking/2919-bump-sdk.md new file mode 100644 index 00000000000..33d5920bf0a --- /dev/null +++ b/.changelog/unreleased/state-breaking/2919-bump-sdk.md @@ -0,0 +1,5 @@ +- Bump [cosmos-sdk](https://github.com/cosmos/cosmos-sdk) to + [v0.47.8-ics-lsm](https://github.com/cosmos/cosmos-sdk/tree/v0.47.8-ics-lsm). + This is a special cosmos-sdk branch with support for both ICS and LSM. + ([\#2919](https://github.com/cosmos/gaia/pull/2919)) + - Skip running `addDenomReverseIndex` in `bank/v3` migration as it is prohibitively expensive to run on the Cosmos Hub. ([sdk-#19266](https://github.com/cosmos/cosmos-sdk/pull/19266)) \ No newline at end of file diff --git a/go.mod b/go.mod index 0902c9a25d0..9caaebaa070 100644 --- a/go.mod +++ b/go.mod @@ -219,7 +219,7 @@ replace ( github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0 // Use special SDK v0.47.x release with support for both ICS and LSM - github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.47.7-0.20240202092001-7a03edbbb4fb + github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm // TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134 github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2 @@ -235,4 +235,4 @@ replace ( google.golang.org/grpc => google.golang.org/grpc v1.54.0 ) -replace github.com/cosmos/interchain-security/v3 => github.com/cosmos/interchain-security/v3 v3.3.1-0.20240201164551-bde0df5adfef +replace github.com/cosmos/interchain-security/v3 => github.com/cosmos/interchain-security/v3 v3.3.1-lsm diff --git a/go.sum b/go.sum index 0d63ae478ed..3381f383fed 100644 --- a/go.sum +++ b/go.sum @@ -600,8 +600,8 @@ github.com/cosmos/btcutil v1.0.5 h1:t+ZFcX77LpKtDBhjucvnOH8C2l2ioGsBNEQ3jef8xFk= github.com/cosmos/btcutil v1.0.5/go.mod h1:IyB7iuqZMJlthe2tkIFL33xPyzbFYP0XVdS8P5lUPis= github.com/cosmos/cosmos-proto v1.0.0-beta.2 h1:X3OKvWgK9Gsejo0F1qs5l8Qn6xJV/AzgIWR2wZ8Nua8= github.com/cosmos/cosmos-proto v1.0.0-beta.2/go.mod h1:+XRCLJ14pr5HFEHIUcn51IKXD1Fy3rkEQqt4WqmN4V0= -github.com/cosmos/cosmos-sdk v0.47.7-0.20240202092001-7a03edbbb4fb h1:DkGuGNs3PIndGvPysqME2QsEsz5JFeNsg9hmNSM8YEk= -github.com/cosmos/cosmos-sdk v0.47.7-0.20240202092001-7a03edbbb4fb/go.mod h1:Rx0pFb7vaFKsgRjFpBzUB+1HT4sQm11MHADdkpJlvuc= +github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm h1:CcNTIPRvn5Q+Xb5Y4RC4hGQZl4r6TuWlWcG7YaIEwj0= +github.com/cosmos/cosmos-sdk v0.47.8-ics-lsm/go.mod h1:Rx0pFb7vaFKsgRjFpBzUB+1HT4sQm11MHADdkpJlvuc= github.com/cosmos/go-bip39 v0.0.0-20180819234021-555e2067c45d/go.mod h1:tSxLoYXyBmiFeKpvmq4dzayMdCjCnu8uqmCysIGBT2Y= github.com/cosmos/go-bip39 v1.0.0 h1:pcomnQdrdH22njcAatO0yWojsUnCO3y2tNoV1cb6hHY= github.com/cosmos/go-bip39 v1.0.0/go.mod h1:RNJv0H/pOIVgxw6KS7QeX2a0Uo0aKUlfhZ4xuwvCdJw= @@ -618,8 +618,8 @@ github.com/cosmos/ibc-go/v7 v7.3.2 h1:FeUDcBX7VYY0e0iRmcVkPPUjYfAqIc//QuHXo8JHz9 github.com/cosmos/ibc-go/v7 v7.3.2/go.mod h1:IMeOXb7gwpZ+/nOG5BuUkdW4weM1ezvN4PQPws4uzOI= github.com/cosmos/ics23/go v0.10.0 h1:iXqLLgp2Lp+EdpIuwXTYIQU+AiHj9mOC2X9ab++bZDM= github.com/cosmos/ics23/go v0.10.0/go.mod h1:ZfJSmng/TBNTBkFemHHHj5YY7VAU/MBU980F4VU1NG0= -github.com/cosmos/interchain-security/v3 v3.3.1-0.20240201164551-bde0df5adfef h1:OF0aInyyWvt2Tf7gOh9+osMaWf24NbAztmJ8CVaiKRk= -github.com/cosmos/interchain-security/v3 v3.3.1-0.20240201164551-bde0df5adfef/go.mod h1:Q89a787cM5Ag+lw7diP/HCqfQnZMpnDKfWLdUNyuRFM= +github.com/cosmos/interchain-security/v3 v3.3.1-lsm h1:FWKVQErMUo+pkTh3I96zF0A9WdrbPW/nT3LbcuiDgNI= +github.com/cosmos/interchain-security/v3 v3.3.1-lsm/go.mod h1:GPr+lDtJOFWyEK+q4Lz/0Ip2IrXF6ntpjwhIkBiiAZI= github.com/cosmos/keyring v1.2.0 h1:8C1lBP9xhImmIabyXW4c3vFjjLiBdGCmfLUfeZlV1Yo= github.com/cosmos/keyring v1.2.0/go.mod h1:fc+wB5KTk9wQ9sDx0kFXB3A0MaeGHM9AwRStKOQ5vOA= github.com/cosmos/ledger-cosmos-go v0.12.4 h1:drvWt+GJP7Aiw550yeb3ON/zsrgW0jgh5saFCr7pDnw=